Skip to content

Commit a34b2ca

Browse files
authored
Add noble-testing to enable kilted beta use (#82)
* Extend matrix to have a noble-testing version Signed-off-by: Emerson Knapp <[email protected]>
1 parent 44859b8 commit a34b2ca

File tree

3 files changed

+38
-19
lines changed

3 files changed

+38
-19
lines changed

.github/workflows/build.yml

Lines changed: 21 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,24 @@ on:
99
- cron: '0 0 * * *'
1010

1111
jobs:
12-
build_ubuntu_docker_image:
12+
ubuntu_base:
1313
strategy:
1414
fail-fast: false
1515
matrix:
16-
base_image_name: [ubuntu]
17-
base_image_tag: [focal, jammy, noble]
18-
name: "${{ matrix.base_image_name }}-${{ matrix.base_image_tag }}"
16+
include:
17+
- source_tag: focal
18+
target_tag: focal
19+
ros_version: ros
20+
- source_tag: jammy
21+
target_tag: jammy
22+
ros_version: ros2
23+
- source_tag: noble
24+
target_tag: noble
25+
ros_version: ros2
26+
- source_tag: noble
27+
target_tag: noble-testing
28+
ros_version: ros2-testing
29+
name: "ubuntu-${{ matrix.target_tag }}"
1930
# always use latest linux worker, as it should not have any impact
2031
# when it comes to building docker images.
2132
runs-on: ubuntu-latest
@@ -47,15 +58,16 @@ jobs:
4758
platforms: linux/amd64,linux/arm64
4859
push: ${{ github.event_name != 'pull_request' }}
4960
build-args: |
50-
BASE_IMAGE_NAME=${{ matrix.base_image_name }}
51-
BASE_IMAGE_TAG=${{ matrix.base_image_tag }}
61+
BASE_IMAGE_NAME=ubuntu
62+
BASE_IMAGE_TAG=${{ matrix.source_tag }}
5263
VCS_REF=${{ github.sha }}
5364
ROS_DISTRO=none
65+
ROS_VERSION=${{ matrix.ros_version }}
5466
tags: |
55-
rostooling/setup-ros-docker:${{ matrix.base_image_name }}-${{ matrix.base_image_tag }}-latest
56-
ghcr.io/ros-tooling/setup-ros-docker/setup-ros-docker-${{ matrix.base_image_name }}-${{ matrix.base_image_tag }}:master
67+
rostooling/setup-ros-docker:ubuntu-${{ matrix.target_tag }}-latest
68+
ghcr.io/ros-tooling/setup-ros-docker/setup-ros-docker-ubuntu-${{ matrix.target_tag }}:latest
5769
58-
build_ubuntu_docker_image_ros:
70+
ros_variant:
5971
strategy:
6072
fail-fast: false
6173
matrix:

Dockerfile

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,9 @@ ARG VCS_REF
2323
# The ROS distribution being targeted by this image
2424
ARG ROS_DISTRO
2525

26+
# Override default APT sources, "ros", "ros2, or "ros2-testing"
27+
ARG ROS_VERSION=''
28+
2629
# Additional APT packages to be installed
2730
#
2831
# This is used to build Docker images incorporating various ROS, or ROS 2

setup-ros.sh

Lines changed: 14 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -33,17 +33,21 @@ apt-get install --no-install-recommends --quiet --yes tzdata
3333
update-ca-certificates
3434
curl -sSL https://raw.githubusercontent.com/ros/rosdistro/master/ros.key -o /usr/share/keyrings/ros-archive-keyring.gpg
3535

36-
ROS_VERSION="ros"
3736
RTI_CONNEXT_DDS=""
38-
case ${ROS_DISTRO} in
39-
"noetic")
40-
ROS_VERSION="ros"
41-
;;
42-
*)
43-
RTI_CONNEXT_DDS="rti-connext-dds-6.0.1"
44-
ROS_VERSION="ros2"
45-
;;
46-
esac
37+
38+
if [ -z $ROS_VERSION ]; then
39+
ROS_VERSION='ros2'
40+
case ${ROS_DISTRO} in
41+
"noetic")
42+
ROS_VERSION="ros"
43+
;;
44+
*)
45+
RTI_CONNEXT_DDS="rti-connext-dds-6.0.1"
46+
ROS_VERSION="ros2"
47+
;;
48+
esac
49+
fi
50+
4751
echo "deb [arch=$(dpkg --print-architecture) signed-by=/usr/share/keyrings/ros-archive-keyring.gpg] http://packages.ros.org/${ROS_VERSION}/ubuntu $(lsb_release -sc) main" |\
4852
tee /etc/apt/sources.list.d/${ROS_VERSION}.list > /dev/null
4953

0 commit comments

Comments
 (0)