Skip to content
This repository has been archived by the owner on Dec 14, 2022. It is now read-only.

Enable all tests on OSX (disable docker tests only in Github Action CI OSX runners) #213

Open
2 tasks
emersonknapp opened this issue Jun 18, 2020 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@emersonknapp
Copy link
Contributor

Description

Currently, the tests in the test suite that use Docker are disabled on OSX. This isn't a hard requirement, it is only the case because the GitHub Action CI OSX runner hosts don't have (and won't have) Docker. Instead of disabling universally, allow configuration (via environment variable?) to disable Docker-based tests at runtime.

This way, development on OSX runs full test suite.

Related Issues

N/A

Completion Criteria

  • Developer on OSX running tox -e py runs entire test suite by default.
  • Action CI on OSX can disable the Docker-based tests at runtime

Implementation Notes / Suggestions

Maybe an environment variable?

Testing Notes / Suggestions

N/A - this enables more tests in more environments.

@emersonknapp emersonknapp added the enhancement New feature or request label Jun 18, 2020
@emersonknapp emersonknapp added good first issue Good for newcomers help wanted Extra attention is needed labels Jul 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant