Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failure on Galactic #825

Open
jtbandes opened this issue May 31, 2023 · 4 comments
Open

Test failure on Galactic #825

jtbandes opened this issue May 31, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@jtbandes
Copy link
Member

Description

We recently had tests start failing on galactic:

https://github.com/foxglove/schemas/actions/runs/5137329133/jobs/9245476136

  /usr/bin/bash -c source /opt/ros/galactic/setup.sh && colcon test-result --verbose
  build/foxglove_msgs/Testing/20230531-2033/Test.xml: 28 tests, 0 errors, 2 failures, 0 skipped
  - pep257_rosidl_generated_py
    <<< failure message
      -- run_test.py: invoking following command in '/__w/schemas/schemas/ros_ws/src/1itt8uep1co/schemas/ros_foxglove_msgs':
       - /opt/ros/galactic/bin/ament_pep257 --xunit-file /__w/schemas/schemas/ros_ws/build/foxglove_msgs/test_results/foxglove_msgs/pep257_rosidl_generated_py.xunit.xml /__w/schemas/schemas/ros_ws/build/foxglove_msgs/rosidl_generator_py/foxglove_msgs
      Traceback (most recent call last):
        File "/opt/ros/galactic/bin/ament_pep257", line 11, in <module>
          load_entry_point('ament-pep257==0.10.7', 'console_scripts', 'ament_pep257')()
        File "/opt/ros/galactic/lib/python3.8/site-packages/ament_pep257/main.py", line 126, in main
          report = generate_pep257_report(args.paths, excludes, args.ignore, args.select,
        File "/opt/ros/galactic/lib/python3.8/site-packages/ament_pep257/main.py", line 192, in generate_pep257_report
          for filename, checked_codes, ignore_decorators in files_to_check:
      ValueError: too many values to unpack (expected 3)
      -- run_test.py: return code 1
      -- run_test.py: generate result file '/__w/schemas/schemas/ros_ws/build/foxglove_msgs/test_results/foxglove_msgs/pep257_rosidl_generated_py.xunit.xml' with failed test
      -- run_test.py: verify result file '/__w/schemas/schemas/ros_ws/build/foxglove_msgs/test_results/foxglove_msgs/pep257_rosidl_generated_py.xunit.xml'
    >>>

CI workflow is here: https://github.com/foxglove/schemas/blob/main/.github/workflows/ci.yml

This error seems to be the same as #795, but that's marked closed and was for rolling anyway.

System (please complete the following information)

  • OS: GitHub Actions ubuntu-latest
  • ROS 2 Distro: Galactic
@jtbandes jtbandes added the bug Something isn't working label May 31, 2023
@christophebedard
Copy link
Member

christophebedard commented May 31, 2023

This is due to a new version of pydocstyle (6.2.0). It was fixed in ament_lint (ament/ament_lint#428), but it wasn't backported to Galactic since it's EOL.

The problem here is that you're getting a new version of pydocstyle even on Focal. This is because it's installed using pip: https://github.com/ros-tooling/setup-ros-docker/blob/fae3c8d623e6f9fc930794e05b96663dcae189d4/setup-ros.sh#L148. This is similar to ros-tooling/setup-ros#535: we should switch to using system packages instead of pip (to match the current installation instructions).

@jtbandes
Copy link
Member Author

Thank you for the quick response! Is there a work in progress or ETA on that fix?

@christophebedard
Copy link
Member

christophebedard commented May 31, 2023

Not sure about the ETA. I've started working on it for setup-ros (but don't have much time), but for setup-ros-docker it would probably be way quicker, since we only need to copy each distro's installation instructions without any code/TypeScript.

The workaround is to remove the newer version of pydocstyle installed by pip and install pydocstyle from apt before the action-ros-ci step.

@jtbandes
Copy link
Member Author

Thanks for the tip, I was able to work around it like this foxglove/schemas@f01e9cc (borrowed from ros2-rust/ros2_rust#302)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants