-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to multiple WORDLISTs #80
Comments
I think this makes sense. Does this also require changes in |
Hmm, that's a good question. I'm not quite sure to be honest. Maybe a two steps approach is reasonable? We could start by offering more flexibility in Otherwise, it seems easy to update |
I added a relatively simple solution so that you can set a |
I released a new CRAN version if you want to test this in your organization. |
Automated spellchecking in my organization is causing friction because we're using a lot of domain-specific vocabulary that get erroneously flagged by spelling.
I understand this is solved by adding the words on a case-by-case basis to the
WORDLIST
but the extra step is generating frustration for something that is perceived as a false positive.To solve this, it would be helpful to pre-seed a
WORDLIST
with common domain-specific words that we use across the organization.However, this doesn't play very well with the current spelling recommended workflow since
WORDLIST
is often regenerated automatically and these pre-seeded words will be removed if unused at this stage.A potential solution would be to have two
WORDLIST
s:update_wordlist()
In terms of interface, a good way I could see this working would be to turn
spell_check_package(use_wordlist = TRUE)
intospell_check_package(wordlist = "inst/WORDLIST")
. In other words, replacing the current boolean argument by a (vector of) paths to the WORDLIST.For the problem described here, the solution would then be:
This feature would also probably help with #64.
If you agree that's a desirable change, I'm happy to submit a PR for this.
The text was updated successfully, but these errors were encountered: