Skip to content
This repository was archived by the owner on May 10, 2022. It is now read-only.

Review dplyr's filter boolean logic implementation. #11

Open
statwonk opened this issue Mar 1, 2016 · 3 comments
Open

Review dplyr's filter boolean logic implementation. #11

statwonk opened this issue Mar 1, 2016 · 3 comments

Comments

@statwonk
Copy link
Contributor

statwonk commented Mar 1, 2016

I really like dplyr's filter(this | that) (and also filter(this %or% that), it'd be nice to implement that here.

@sckott
Copy link
Contributor

sckott commented Mar 9, 2016

can you give an example of what that looks like?

@statwonk
Copy link
Contributor Author

For my own reference, this is where dplyr::filter lives, https://github.com/hadley/dplyr/blob/344d23c934c3a3c0e26aef4abfaf49a644cb0d5a/R/manip.r#L19

@statwonk
Copy link
Contributor Author

filter_.tbl_df: https://github.com/hadley/dplyr/blob/19ae0ce5ef828a984ba04ae8a0741e768159eb66/R/tbl-df.r#L187

One key check has_names, input is an R-like predicate and shouldn't have names.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants