You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently in roosevelt.js line 225 as seen below, we have code to run the client views bundler, preprocessing CSS, parsing through isomorphic controllers, and bundling JS
The issue I found recently was due to preprocessCss.js and jsBundler.js being async with promises within them, there is a chance that the JS bundler could start running before the viewsBundler finishes. As a suggestion, I think we should move the views bundler code to the top of these few requires so it runs first (and since it is synchronous, it will block and not let anything run before it is done). As well we may want to look into refactoring preprocessCss and jsBundler to be more explicit that they are promises and add some await calls to make things more explicit.
The text was updated successfully, but these errors were encountered:
Currently in roosevelt.js line 225 as seen below, we have code to run the client views bundler, preprocessing CSS, parsing through isomorphic controllers, and bundling JS
The issue I found recently was due to
preprocessCss.js
andjsBundler.js
being async with promises within them, there is a chance that the JS bundler could start running before the viewsBundler finishes. As a suggestion, I think we should move the views bundler code to the top of these few requires so it runs first (and since it is synchronous, it will block and not let anything run before it is done). As well we may want to look into refactoring preprocessCss and jsBundler to be more explicit that they are promises and add someawait
calls to make things more explicit.The text was updated successfully, but these errors were encountered: