Skip to content

Commit 58d3f92

Browse files
Avi Sharvitezr-ondrej
Avi Sharvit
authored andcommitted
Fixes #27115 - Fix eslint errors
1 parent 280aca0 commit 58d3f92

File tree

9 files changed

+19
-1
lines changed

9 files changed

+19
-1
lines changed

webpack/assets/javascripts/react_app/components/Editor/Editor.js

+3
Original file line numberDiff line numberDiff line change
@@ -206,6 +206,9 @@ Editor.propTypes = {
206206
name: PropTypes.string,
207207
title: PropTypes.string,
208208
renderPath: PropTypes.string,
209+
hosts: PropTypes.array,
210+
locked: PropTypes.bool,
211+
type: PropTypes.string,
209212
}).isRequired,
210213
selectedHost: PropTypes.shape({
211214
id: PropTypes.oneOfType([PropTypes.string, PropTypes.number]),

webpack/assets/javascripts/react_app/components/FactCharts/FactChart.js

+1
Original file line numberDiff line numberDiff line change
@@ -112,6 +112,7 @@ FactChart.propTypes = {
112112
id: PropTypes.number.isRequired,
113113
title: PropTypes.string,
114114
search: PropTypes.string,
115+
path: PropTypes.string,
115116
}).isRequired,
116117
factChart: PropTypes.shape({
117118
chartData: PropTypes.arrayOf(PropTypes.array),

webpack/assets/javascripts/react_app/components/Layout/Layout.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -163,6 +163,7 @@ Layout.propTypes = {
163163
})
164164
),
165165
data: PropTypes.shape({
166+
brand: PropTypes.string,
166167
menu: PropTypes.arrayOf(
167168
PropTypes.shape({
168169
type: PropTypes.string.isRequired,
@@ -182,7 +183,7 @@ Layout.propTypes = {
182183
),
183184
}),
184185
orgs: PropTypes.shape({
185-
current_organization: PropTypes.string,
186+
current_org: PropTypes.string,
186187
available_organizations: PropTypes.arrayOf(
187188
PropTypes.shape({
188189
href: PropTypes.string.isRequired,

webpack/assets/javascripts/react_app/components/Pagination/Pagination.js

+3
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,9 @@ Pagination.propTypes = {
5959
perPageOptions: PropTypes.arrayOf(PropTypes.number),
6060
itemCount: PropTypes.number,
6161
perPage: PropTypes.number,
62+
classNames: PropTypes.shape({
63+
pagination_classes: PropTypes.string,
64+
}),
6265
}).isRequired,
6366
onPageSet: PropTypes.func,
6467
onPerPageSelect: PropTypes.func,

webpack/assets/javascripts/react_app/components/Template/TemplateInput.js

+2
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,8 @@ const TemplateInput = ({
5959

6060
TemplateInput.propTypes = {
6161
data: PropTypes.shape({
62+
id: PropTypes.oneOfType([PropTypes.string, PropTypes.number]),
63+
type: PropTypes.string,
6264
url: PropTypes.string,
6365
resourceType: PropTypes.string,
6466
initialError: PropTypes.string,

webpack/assets/javascripts/react_app/components/common/DateTimePicker/DateComponents/DateInput.js

+2
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@ class DateInput extends React.Component {
1515
componentDidUpdate = prevProps => {
1616
const newDate = this.props.date;
1717
if (prevProps.date !== newDate) {
18+
// TODO: Fix #27114 - stop violating react/no-did-update-set-state
19+
// eslint-disable-next-line react/no-did-update-set-state
1820
this.setState({
1921
date: newDate,
2022
typeOfDateInput: this.props.typeOfDateInput,

webpack/assets/javascripts/react_app/components/common/DateTimePicker/DateComponents/MonthView.js

+2
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,8 @@ class MonthView extends React.Component {
2121
componentDidUpdate = prevProps => {
2222
const newDate = this.props.date;
2323
if (prevProps.date !== newDate) {
24+
// TODO: Fix #27114 - stop violating react/no-did-update-set-state
25+
// eslint-disable-next-line react/no-did-update-set-state
2426
this.setState({
2527
selectedDate: newDate,
2628
date: newDate,

webpack/assets/javascripts/react_app/components/common/DateTimePicker/TimeComponents/PickTimeClock.js

+2
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@ class PickTimeClock extends React.Component {
1010
componentDidUpdate = prevProps => {
1111
const newTime = this.props.time;
1212
if (prevProps.time !== newTime) {
13+
// TODO: Fix #27114 - stop violating react/no-did-update-set-state
14+
// eslint-disable-next-line react/no-did-update-set-state
1315
this.setState({ ampm: newTime.getHours() >= 12 ? 'PM' : 'AM' });
1416
}
1517
};

webpack/assets/javascripts/react_app/components/common/DateTimePicker/TimeComponents/TimeInput.js

+2
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,8 @@ class TimeInput extends React.Component {
1313
componentDidUpdate = prevProps => {
1414
const { time: nextTime, isTimeTableOpen } = this.props;
1515
if (prevProps.time !== nextTime) {
16+
// TODO: Fix #27114 - stop violating react/no-did-update-set-state
17+
// eslint-disable-next-line react/no-did-update-set-state
1618
this.setState({
1719
isTimeTableOpen,
1820
});

0 commit comments

Comments
 (0)