Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade typescript & other packages #157

Merged
merged 101 commits into from
Apr 1, 2024
Merged
Show file tree
Hide file tree
Changes from 99 commits
Commits
Show all changes
101 commits
Select commit Hold shift + click to select a range
c6d2536
Make change to assume dest folder. Delete 2 old tests that looked for…
MilapNaik Jan 2, 2024
2ba8eca
Sort files
MilapNaik Jan 2, 2024
cc92e04
Update src/RokuDeploy.ts
MilapNaik Jan 16, 2024
9bbd579
Removed redundant entry.dest is null situation
MilapNaik Jan 17, 2024
460cbf6
Added a few commands, not all are working correctly
MilapNaik Jan 19, 2024
de269ed
Merge branch 'v4' into add-cli-commands
MilapNaik Jan 19, 2024
7b9ee29
Merge branch 'fix-src-dest-handling' into add-cli-commands
MilapNaik Jan 19, 2024
6db962a
Move commands to their own file
MilapNaik Jan 31, 2024
20eb21f
More command files
MilapNaik Feb 1, 2024
4e4b66a
Change commands to help with tests
MilapNaik Feb 1, 2024
2b809e6
Add testing suite for all cli (2 tests are not working)
MilapNaik Feb 2, 2024
13f2ca4
Updated cli file after adding in commands and tests
MilapNaik Feb 2, 2024
2d13441
Fixed a few test cases
MilapNaik Feb 2, 2024
09a275f
Change name and input of table helper
MilapNaik Feb 2, 2024
e34ac97
Totally broken code, but have the right names
TwitchBronBron Feb 2, 2024
52b1bc0
Changed name of toTable
MilapNaik Feb 6, 2024
f3a0c56
Make test for objectToTable
MilapNaik Feb 6, 2024
b5f41ca
add yargs to pacjage.json
MilapNaik Feb 6, 2024
4b95943
add package-lock.json
MilapNaik Feb 6, 2024
b6c6223
add new line at eof
MilapNaik Feb 6, 2024
f15f295
Add test for coverage, also remove an unncessary '?'
MilapNaik Feb 6, 2024
08a587e
Merge branch 'add-cli-commands' into rename
MilapNaik Feb 6, 2024
6941e86
tweaks
TwitchBronBron Feb 6, 2024
ea49342
tweaks
TwitchBronBron Feb 6, 2024
616ff23
get from json stuff
TwitchBronBron Feb 6, 2024
e2f3f80
Merge branch 'v4' into rename
MilapNaik Feb 6, 2024
190a2f1
Merge branch 'v4' into rename
MilapNaik Feb 6, 2024
cacf433
Correct imports
MilapNaik Feb 7, 2024
cbd6417
Last of the fsExtra changes
MilapNaik Feb 7, 2024
ebab568
Create a load from json util, clean up cli.ts file with fleshing out …
MilapNaik Feb 21, 2024
46fe129
Adding cli tests
MilapNaik Feb 22, 2024
36502e1
Delete deployAndSignPackage tests, a deleted function in rokudeploy
MilapNaik Feb 22, 2024
c058dd6
Add defaultsFromJson tests
MilapNaik Feb 22, 2024
5859f91
Move some tests to utils test file, re add other functions that might…
MilapNaik Feb 29, 2024
8ae9ace
Change signExistingPackage to CreateSignedPackage
MilapNaik Feb 29, 2024
cc0f4b8
Delete retrieveSignedPackage
MilapNaik Feb 29, 2024
cbfcaed
Move getFilePaths
MilapNaik Feb 29, 2024
c74ef8e
Random changes I forgot to put in the other pushes
MilapNaik Feb 29, 2024
583d960
Change to different notation since getOutputZipFilePath and getOutput…
MilapNaik Feb 29, 2024
6d874a6
Change notation for normalizeDeviceInfoFieldValue since it was made p…
MilapNaik Feb 29, 2024
f5ba839
Change notation for parsedManifestFromString and ParseManifest since …
MilapNaik Feb 29, 2024
2858dd6
Change deleteInstalledChannel to deleteDevChannel, other small changes
MilapNaik Feb 29, 2024
3186e88
Add stagingDir, fix zip/deleteDevChannel/captureScreenshot function c…
MilapNaik Mar 4, 2024
55ce426
Fix commands
MilapNaik Mar 4, 2024
8d4e537
change defaults from json function, fix some tests
MilapNaik Mar 5, 2024
1d75b10
fix index, fix makezip, getfilepaths, sideload
MilapNaik Mar 5, 2024
48d07d9
Add options from json ability to each command to each command
MilapNaik Mar 5, 2024
053a3f4
remove bsconfig, fix cli file with key press commands, fix key press …
MilapNaik Mar 5, 2024
fa07787
fix getoptionsfromjson
MilapNaik Mar 5, 2024
4344666
delete unnecessary commands, fix some tests
MilapNaik Mar 6, 2024
7d9e56e
change to captureScreenshot
MilapNaik Mar 6, 2024
ebb3d22
Fix a bunch of tests
MilapNaik Mar 8, 2024
243bbdd
Fix up the last few tests and cli commands
MilapNaik Mar 11, 2024
b485ea4
Changing coverage check to false
MilapNaik Mar 11, 2024
7ad7ff0
Fix failing tests on windows
TwitchBronBron Mar 11, 2024
fad56b9
Delete comment
MilapNaik Mar 11, 2024
b51c3fc
Change publish to sideload everywhere else
MilapNaik Mar 15, 2024
0da4110
Move deploy tests to test exec command
MilapNaik Mar 18, 2024
2ad743a
Throw new error for wrong device id, and add test to test for it
MilapNaik Mar 18, 2024
e6d8752
Delete creating variable options since it was unused
MilapNaik Mar 18, 2024
200e537
Add function description
MilapNaik Mar 18, 2024
a669ee3
Inline exec command options
MilapNaik Mar 18, 2024
906856e
Remove retainsStagingDir, zipCallBackInfo, incrementBuildNumber, and …
MilapNaik Mar 19, 2024
d065bd5
Delete convertToSquashfs, move deployAndSignPackage tests to cli, mov…
MilapNaik Mar 19, 2024
0f17569
Change prepublishToStaging to stage
MilapNaik Mar 20, 2024
94fa701
Change the way close channel works
MilapNaik Mar 20, 2024
f64ab5d
Update src/RokuDeploy.ts
MilapNaik Mar 20, 2024
4ffc8f7
Add outFile to Zip, delete zipPackage
MilapNaik Mar 20, 2024
94a4d43
StagingDir is defaulted anyway so this error will never occur
MilapNaik Mar 20, 2024
782ec22
Delete MissingRequiredOptionError
MilapNaik Mar 20, 2024
895c250
Add checkRequiredOptions function to test for required options
MilapNaik Mar 20, 2024
469a62a
Add checking for required options in sendKeyEvent function, start tes…
MilapNaik Mar 20, 2024
76b1f7d
Add check for if options are part of the defined interface that they …
MilapNaik Mar 23, 2024
9e44992
Add check for various required options and add tests for each one
MilapNaik Mar 23, 2024
3734501
Merge branch 'v4' into throw-exceptions-on-missing-params
MilapNaik Mar 23, 2024
db3d782
take out it.only in tests
MilapNaik Mar 23, 2024
e11ae26
Delete old MissingRequiredOptionError tests
MilapNaik Mar 23, 2024
b298acb
fix tests
MilapNaik Mar 23, 2024
d9397d5
Fix lint error
MilapNaik Mar 23, 2024
9dd053d
Upgrade as many packages as possible, delete chalk stub
MilapNaik Mar 25, 2024
0bf6dd3
Bring back chalk by downgrading sinon to v12
MilapNaik Mar 26, 2024
ef8a3ec
New package-lock
MilapNaik Mar 26, 2024
1c4b4f1
Upgrade node to 14.7.0
MilapNaik Mar 26, 2024
9eab0ec
Undo last commit wrong branch
MilapNaik Mar 26, 2024
643b565
Upgrade node in build script to 14.17
MilapNaik Mar 26, 2024
1b1bca3
Get rid of individual options checks
MilapNaik Mar 26, 2024
20eaeb7
Fixed option type in tests function
MilapNaik Mar 26, 2024
0d09e4e
Merge remote-tracking branch 'origin/throw-exceptions-on-missing-para…
MilapNaik Mar 26, 2024
c27809c
Fixing eslint libraries to be compatible with the version of node we …
MilapNaik Mar 26, 2024
75cff5b
Fix lint errors: sorting unions and importing types in the same line …
MilapNaik Mar 26, 2024
b5b532b
Fix lint errors: lines around comments set to false, prefer nullish c…
MilapNaik Mar 26, 2024
928b32b
Merge branch 'v4' into upgrade-typescript
MilapNaik Mar 26, 2024
1a8c5c5
Fix 2 more lint errors
MilapNaik Mar 28, 2024
83ee406
Fix jszip error
MilapNaik Mar 28, 2024
c41a97a
Undo last change
MilapNaik Mar 28, 2024
da43675
Turn off prefer optional chain
MilapNaik Mar 28, 2024
896e0af
Disable duplicate imports error one time
MilapNaik Mar 28, 2024
e529688
move eslint to a dev dependency
MilapNaik Mar 28, 2024
a805021
Fix eslint errors
MilapNaik Apr 1, 2024
1f914fa
Added npm install package lock, which actually fixed a different issue
MilapNaik Apr 1, 2024
cb25a04
add eslint plugin import, fix logical-assignment-operators error
MilapNaik Apr 1, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ module.exports = {
'@typescript-eslint/explicit-member-accessibility': 'off',
'@typescript-eslint/explicit-module-boundary-types': 'off',
'@typescript-eslint/init-declarations': 'off',
'@typescript-eslint/lines-around-comment': 'off',
'@typescript-eslint/member-ordering': 'off',
"@typescript-eslint/naming-convention": 'off',
'@typescript-eslint/no-base-to-string': 'off',
Expand Down Expand Up @@ -52,6 +53,8 @@ module.exports = {
'error',
'always'
],
'@typescript-eslint/prefer-nullish-coalescing': 'off',
"@typescript-eslint/prefer-optional-chain": 'off',
'@typescript-eslint/prefer-readonly': 'off',
'@typescript-eslint/prefer-readonly-parameter-types': 'off',
'@typescript-eslint/promise-function-async': 'off',
Expand Down Expand Up @@ -94,7 +97,6 @@ module.exports = {
'init-declarations': 'off',
'line-comment-position': 'off',
'linebreak-style': 'off',
'lines-around-comment': 'off',
'lines-between-class-members': 'off',
'max-classes-per-file': 'off',
'max-depth': 'off',
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
- uses: actions/checkout@master
- uses: actions/setup-node@master
with:
node-version: "12.22.7"
node-version: "14.17.0"
- run: cd src && cd .. #trying to fix "ENOENT: no such file or directory, uv_cwd" error
- run: npm ci
- run: npm run build
Expand All @@ -38,7 +38,7 @@ jobs:
- uses: actions/checkout@master
- uses: actions/setup-node@master
with:
node-version: "10.19.0"
node-version: "14.17.0"
- run: echo "//registry.npmjs.org/:_authToken=${NPM_TOKEN}" > ./.npmrc
- run: npm ci
- run: npm run build
Expand Down
Loading
Loading