Add cli commands and rename roku-deploy functions, reorganize functions #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… old behavior, add 2 more tests that look for new behavior
Co-authored-by: Bronley Plumb <[email protected]>
# Conflicts: # src/RokuDeploy.ts
# Conflicts: # src/util.ts
# Conflicts: # src/RokuDeploy.ts # src/cli.ts # src/commands/DeleteInstalledChannelCommand.ts # src/commands/GetDeviceInfoCommand.ts # src/commands/PrepublishCommand.ts # src/commands/PublishCommand.ts # src/commands/SignExistingPackageCommand.ts # src/commands/TakeScreenshotCommand.ts # src/commands/ZipPackageCommand.ts # src/index.ts # src/util.spec.ts # src/util.ts
# Conflicts: # src/index.ts
…functions and add options
TwitchBronBron
changed the title
TwitchBronBron
commented
Mar 11, 2024
| @@ -101,7 +101,7 @@ | |||
| ], | |||
| "sourceMap": true, | |||
| "instrument": true, | |||
| "check-coverage": true, | |||
| "check-coverage": false, | |||
There was a problem hiding this comment.
We'll re-enable this once most of v4 is finished. No need to chase 100% right now
…add back tests for createPackage
…e retrieveSignedPackage tests to under createSignedPackage
TwitchBronBron
commented
Mar 20, 2024
TwitchBronBron
commented
Mar 20, 2024
TwitchBronBron
commented
Mar 20, 2024
Co-authored-by: Bronley Plumb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds all method and CLI renames we want to do. This thing is totally broken though, needs lots of love. :D
Fixes #70
Fixes #138