Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge multi-argument functions into single options functions #140

Closed
TwitchBronBron opened this issue Feb 2, 2024 · 1 comment
Closed
Milestone

Comments

@TwitchBronBron
Copy link
Member

Several core functions in RokuDeploy take multiple arguments. We've been aligning on a single options object for many of our calls, so we should do another pass to ensure that mutli-argument functions are only multi-argument when absolutely necessary.

One example (not exclusive):
retrieveSignedPackage takes 2 arguments

public async retrieveSignedPackage(pkgPath: string, options: RetrieveSignedPackageOptions): Promise<string> {

but should be:

public async retrieveSignedPackage( options: RetrieveSignedPackageOptions): Promise<string> {
@TwitchBronBron
Copy link
Member Author

TwitchBronBron commented Mar 5, 2024

Fixed in #126

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant