Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leverage ECP chanperf #122

Open
TwitchBronBron opened this issue Jan 5, 2023 · 0 comments
Open

Leverage ECP chanperf #122

TwitchBronBron opened this issue Jan 5, 2023 · 0 comments

Comments

@TwitchBronBron
Copy link
Member

TwitchBronBron commented Jan 5, 2023

Add support for the chanperf ECP request (instead of using the port 8080 commands).
https://developer.roku.com/en-gb/docs/developer-program/debugging/external-control-api.md#general-ecp-commands

  1. check the firmware version (from the device-info object added in Do device-info query at start of debug session #121) to make sure it's at least firmware 11.0

  2. Add a launch configuration object with this structure:

    "chanperf": {
         enabled: true,
         //  the interval (in milliseconds) that chanperf information should be collected 
         // (i.e. `5000` means run a chanperf request every 5 seconds)
         interval: 1000
    }
  3. The logic should be added into ChanperfTracker.

We still need to fall back to the old telnet scraping method, but if we are able to successfully use the ECP command, then the old method's results should be discarded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant