Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.18.0 removed paginate features #119

Open
mol-george opened this issue Jun 15, 2023 · 0 comments
Open

v0.18.0 removed paginate features #119

mol-george opened this issue Jun 15, 2023 · 0 comments

Comments

@mol-george
Copy link

Hello rockset team,

As far as I can tell the paginate related features were removed in:

## DIFFing files locally
➜ gh repo clone rockset/rockset-go-client
Cloning into 'rockset-go-client'...
[...]
Resolving deltas: 100% (2397/2397), done.

➜ cd rockset-go-client

➜ git diff c91aa14:openapi/model_query_request_sql.go 4b9a1a6:openapi/model_query_request_sql.go | grep "^\+[^+]\|^-[^-]" | grep -wi paginate
-	// Flag to paginate and store the results of this query for later / sequential retrieval.
-	Paginate *bool `json:"paginate,omitempty"`
-// GetPaginate returns the Paginate field value if set, zero value otherwise.
-	if o == nil || o.Paginate == nil {
-	return *o.Paginate
-// GetPaginateOk returns a tuple with the Paginate field value if set, nil otherwise
-	if o == nil || o.Paginate == nil {
-	return o.Paginate, true
-	if o != nil && o.Paginate != nil {
-// SetPaginate gets a reference to the given bool and assigns it to the Paginate field.
-	o.Paginate = &v
-	if o.Paginate != nil {
-		toSerialize["paginate"] = o.Paginate

You can also check openapi/model_query_request_sql.go PR #103 diff.

This broke our code which was relying on this feature.

Can you please confirm that this features were removed on purpose and you plan to re-introduce it in the future?
If not please advise what we could use instead.

Thank you for your support with this issue!

Regards,
George M.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant