New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

warning C4103: alignment changed after including header #66

Open

traversaro opened this issue Aug 29, 2022 · 1 comment

Member

traversaro commented Aug 29, 2022 •

edited

Loading

While compiling another project, I noticed a lot of warnings of this form on MSVC:

2022-06-21T21:12:53.8896867Z D:\a\icub-firmware-shared\icub-firmware-shared\eth\embobj\core\core\EoCommon.h(76,1): warning C4103: alignment changed after including header, may be due to missing #pragma pack(pop) [D:\a\icub-firmware-shared\icub-firmware-shared\build\eth\embobj.vcxproj]

Indeed, this seems to be related to https://github.com/robotology/icub-firmware-shared/blob/v1.25.1/eth/embobj/core/core/embOBJporting.h#L145 . Perhaps the absence of pack(pop) is intendend, but anyhow I preferred to report this warning just in case, as this may lead to tricky ABI-related bugs.

The text was updated successfully, but these errors were encountered:

Member

pattacini commented Aug 29, 2022

cc @marcoaccame

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment