Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"With opacity" function unclear or not working #5

Open
LordSmokedMeatsAndFishes opened this issue Mar 6, 2014 · 9 comments
Open

"With opacity" function unclear or not working #5

LordSmokedMeatsAndFishes opened this issue Mar 6, 2014 · 9 comments

Comments

@LordSmokedMeatsAndFishes

I expect it to change the opacity of the reading window, but it doesn't. So it either does something else that I haven't figured out, or it is not working on Firefox 24.3.0 / OS X 10.6.8.

@robbiehinch
Copy link
Owner

If the opacity is 0, there is no border for the readin areas, and there is an 'x' button to close reasy. Opacity sets how much the border obscures the webpage behind, and you can click anywhere in the border to close reasy

@LordSmokedMeatsAndFishes
Copy link
Author

I see, thanks. Then it's definitely not working for me. I had the closebutton when I first installed it; changing opacity made the closebutton disappear but did not show a border; and changing it back to 0 did not restore the closebutton. I close the reading area by clicking anywhere on the page outside the area.

@robbiehinch
Copy link
Owner

Sorry, when I said the border, I mean what you called 'anywhere on the page outside the area.'. If you set opacity to more than 20 or so you should see this area getting closer to the reading area background colour. The X might not have appeared after you set 0 because you might need to reload the page as discussed in one of these other issues?

@LordSmokedMeatsAndFishes
Copy link
Author

I see. I guess I would think of that as "page overlay". No, I can't get opacity 0 or 100 to make any difference, and I can't get the closebox back, even if I restart the browser. The only thing that affects the color of the overlay for me is "dim original page by (percent)"; I have it set to 33.

@robbiehinch
Copy link
Owner

Ah, now I remember, sorry I haven't looked at this for years. In fact the With opacity option should be getting applied to the text that is shown if you enable the show leading and trailing line option.

and dim original page by (percent) is the option I was trying to explain up to now.

@LordSmokedMeatsAndFishes
Copy link
Author

I see! And the closebox comes back if the dim is set to 0, perfect. So, maybe some wording clarification on the preference panes is in order.... Otherwise it's a great addon, thanks for making it.

@robbiehinch
Copy link
Owner

I found labelling these options tricky, how would you label them so that they made sense to you?

@LordSmokedMeatsAndFishes
Copy link
Author

I like using elipsis and indentation for anything that depends on something above it.

[] Show leading and triailing line...
...with opacity (percent):
____

And I think a radio button set of 2 is a better match than 1 checkbox for:

() Display immediately...
...after slelecting how many words:
____

() Or wait for action key:
____
...and dim original page by (percent):
____

Multi-line text spacing:


etc. While we're on the subject, I'd also find a hexidecimal RGB value entry field in the color picker very useful....

@robbiehinch
Copy link
Owner

ah yes, like it, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants