Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot confidently determine state of NFTs when filtering by collection (e.g., cli:consolidate --collection) #118

Open
spenweb opened this issue Jul 1, 2022 · 1 comment

Comments

@spenweb
Copy link
Contributor

spenweb commented Jul 1, 2022

The state of a RMRK NFT may depend on interactions including NFTs from another collection. The current implementation of the cli:consolidate tool does not account for this. This means that it is possible for the state of a NFT may be different using a full consolidation versus a consolidation using a collection filter. Is this intentional? If so, I suggest a disclaimer is added to the tool's documentation to make this clear.

Example

For example, let's say you have the following:
Collections

  • HEROES
  • GLASSES

NFTs

  • superman from HEROES
  • spiderman from HEROES
  • sunglasses from GLASSES

Let's assume for whatever reason that any NFT from any collection may be equipped to a NFT in the HEROES collection and that superman is equipped with sunglasses at baseslot somebaseid.slot1. Later the same superman NFT is equipped by spiderman in the same baseslot somebaseid.slot1 but is rejected because that slot has already been filled.

Some time passes and a comic book enthusiast named Malcolm wants all the consolidated HEROES. At first Malcolm doesn't notice the --collection flag so he just runs the following:

yarn cli:consolidate

He notices that this is taking a while and opens up another terminal and runs the following:

yarn cli:consolidate --collection HEROES

Malcolm views superman from the filtered consolidation as it finished already and sees a rendered image of Superman holding Spiderman. Some time passes and he sees that the full consolidation is finished and views the superman NFT from that consolidation and sees Superman holding some sunglasses and there is no Spiderman in sight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants
@spenweb and others