Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Constant Marketplace Fee Trait For Downstream #268

Open
HashWarlock opened this issue Jan 18, 2023 · 0 comments
Open

Add a Constant Marketplace Fee Trait For Downstream #268

HashWarlock opened this issue Jan 18, 2023 · 0 comments
Assignees

Comments

@HashWarlock
Copy link
Contributor

Description

RMRK design has Royalties as a configurable parameter when minting an NFT. However, there is not a mechanism to implement royalties when using the RMRK Market pallet. This will cause marketplace implementations downstream to either fork or tightly couple their own marketplace pallet to RMRK market pallet to enforce royalties and tx fees for the marketplace.

A potential solution would be adding a trait that can be implemented downstream that can allow downstream implementations to set their marketplace royalties and fees while using the same user facing calls in the RMRK market pallet.

Example (WIP)

// Add to RMRK Market Config
type MarketFee: PerBill

trait MarketFeesHandler {
    fn market_fee(collection, nft, amount, T::MarketFee) -> Balance;
    fn royalty_fee(collection, nft, amount, Option<RoyaltyInfo>) -> Balance;
}

More info to come.

@HashWarlock HashWarlock self-assigned this Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant