Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't check every returned object for lazy? #4426

Open
rmosolgo opened this issue Apr 7, 2023 · 1 comment
Open

Don't check every returned object for lazy? #4426

rmosolgo opened this issue Apr 7, 2023 · 1 comment

Comments

@rmosolgo
Copy link
Owner

rmosolgo commented Apr 7, 2023

This check results in a Kernel#class and Kernel#hash check for every returned value in GraphQL:

def lazy?(object)
@lazy_cache.fetch(object.class) {
@lazy_cache[object.class] = @schema.lazy?(object)
}
end
end

Somehow, I need a way to remove that. Strings, Floats, Integers, etc could all be assumed not-lazy?.

@rmosolgo
Copy link
Owner Author

Working up a fix for this in #4592

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant