[core] update parser to better handle whitespace

Author: geemus

benchs/parse_vs_push.rb

@@ -16,6 +16,7 @@ def reset
   end
 
   def characters(string)
+    @value ||= ''
     @value << string.strip
   end
 
@@ -29,10 +30,14 @@ def end_element(name)
       @response[:items] << @item
       @item = {}
     when 'key'
-      @item[:key] = @value
+      @item[:key] = value
     end
   end
 
+  def value
+    @value.dup
+  end
+
 end
 
 data = <<-DATA
@@ -43,18 +48,22 @@ def end_element(name)
 </items>
 DATA
 
-COUNT = 100
+COUNT = 10_000
 
 Benchmark.bmbm(25) do |bench|
   bench.report('parse') do
-    parser = Parser.new
-    Nokogiri::XML::SAX::Parser.new(parser).parse(data)
-    parser.response
+    COUNT.times do
+      parser = Parser.new
+      Nokogiri::XML::SAX::Parser.new(parser).parse(data)
+      parser.response
+    end
   end
 
   bench.report('push') do
-    parser = Parser.new
-    Nokogiri::XML::SAX::PushParser.new(parser).write(data, true)
-    parser.response
+    COUNT.times do
+      parser = Parser.new
+      Nokogiri::XML::SAX::PushParser.new(parser).write(data, true)
+      parser.response
+    end
   end
 end

lib/fog/aws/parsers/cloud_formation/create_stack.rb

@@ -8,7 +8,7 @@ class CreateStack < Fog::Parsers::Base
           def end_element(name)
             case name
             when 'RequestId', 'StackId'
-              @response[name] = @value
+              @response[name] = value
             end
           end
 

lib/fog/aws/parsers/cloud_formation/describe_stack_events.rb

@@ -13,14 +13,14 @@ def reset
           def end_element(name)
             case name
             when 'EventId', 'LogicalResourceId', 'PhysicalResourceId', 'ResourceProperties', 'ResourceStatus', 'ResourceStatusReason', 'ResourceType', 'StackId', 'StackName'
-              @event[name] = @value
+              @event[name] = value
             when 'member'
               @response['StackEvents'] << @event
               @event = {}
             when 'RequestId'
-              @response[name] = @value
+              @response[name] = value
             when 'Timestamp'
-              @event[name] = Time.parse(@value)
+              @event[name] = Time.parse(value)
             end
           end
 

lib/fog/aws/parsers/cloud_formation/describe_stack_resources.rb

@@ -13,14 +13,14 @@ def reset
           def end_element(name)
             case name
             when 'StackId', 'StackName', 'LogicalResourceId', 'PhysicalResourceId', 'ResourceType', 'ResourceStatus'
-              @resource[name] = @value
+              @resource[name] = value
             when 'member'
               @response['StackResources'] << @resource
               @resource = {}
             when 'RequestId'
-              @response[name] = @value
+              @response[name] = value
             when 'Timestamp'
-              @resource[name] = Time.parse(@value)
+              @resource[name] = Time.parse(value)
             end
           end
 

lib/fog/aws/parsers/cloud_formation/describe_stacks.rb

@@ -26,7 +26,7 @@ def end_element(name)
             if @in_outputs
               case name
               when 'OutputKey', 'OutputValue'
-                @output[name] = @value
+                @output[name] = value
               when 'member'
                 @stack['Outputs'] << @output
                 @output = {}
@@ -36,7 +36,7 @@ def end_element(name)
             elsif @in_parameters
               case name
               when 'ParameterKey', 'ParameterValue'
-                @parameter[name] = @value
+                @parameter[name] = value
               when 'member'
                 @stack['Parameters'] << @parameter
                 @parameter = {}
@@ -49,18 +49,18 @@ def end_element(name)
                 @response['Stacks'] << @stack
                 @stack = { 'Outputs' => [], 'Parameters' => [] }
               when 'RequestId'
-                @response[name] = @value
+                @response[name] = value
               when 'CreationTime'
-                @stack[name] = Time.parse(@value)
+                @stack[name] = Time.parse(value)
               when 'DisableRollback'
-                case @value
+                case value
                 when 'false'
                   @stack[name] = false
                 when 'true'
                   @stack[name] = true
                 end
               when 'StackName', 'StackId', 'StackStatus'
-                @stack[name] = @value
+                @stack[name] = value
               end
             end
           end

lib/fog/aws/parsers/cloud_formation/get_template.rb

@@ -8,7 +8,7 @@ class GetTemplate < Fog::Parsers::Base
           def end_element(name)
             case name
             when 'RequestId', 'TemplateBody'
-              @response[name] = @value
+              @response[name] = value
             end
           end
 

lib/fog/aws/parsers/cloud_formation/validate_template.rb

@@ -21,20 +21,20 @@ def start_element(name, attrs = [])
           def end_element(name)
             case name
             when 'DefaultValue', 'ParameterKey'
-              @parameter[name] = @value
+              @parameter[name] = value
             when 'Description'
               if @in_parameters
-                @parameter[name] = @value
+                @parameter[name] = value
               else
-                @response[name] = @value
+                @response[name] = value
               end
             when 'RequestId'
-              @response[name] = @value
+              @response[name] = value
             when 'member'
               @response['Parameters'] << @parameter
               @parameter = {}
             when 'NoEcho'
-              case @value
+              case value
               when 'false'
                 @parameter[name] = false
               when 'true'

lib/fog/aws/parsers/elb/configure_health_check.rb

@@ -17,15 +17,15 @@ def start_element(name, attrs = [])
           def end_element(name)
             case name
             when 'Target'
-              @health_check[name] = @value
+              @health_check[name] = value
             when 'Interval', 'Timeout', 'UnhealthyThreshold', 'HealthyThreshold'
-              @health_check[name] = @value.to_i
+              @health_check[name] = value.to_i
 
             when 'HealthCheck'
               @response['ConfigureHealthCheckResult'][name] = @health_check
 
             when 'RequestId'
-              @response['ResponseMetadata'][name] = @value
+              @response['ResponseMetadata'][name] = value
             end
           end
 

lib/fog/aws/parsers/elb/create_load_balancer.rb

@@ -12,9 +12,9 @@ def reset
           def end_element(name)
             case name
             when 'DNSName'
-              @response['CreateLoadBalancerResult'][name] = @value
+              @response['CreateLoadBalancerResult'][name] = value
             when 'RequestId'
-              @response['ResponseMetadata'][name] = @value
+              @response['ResponseMetadata'][name] = value
             end
           end
 

lib/fog/aws/parsers/elb/delete_load_balancer.rb

@@ -12,7 +12,7 @@ def reset
           def end_element(name)
             case name
             when 'RequestId'
-              @response['ResponseMetadata'][name] = @value
+              @response['ResponseMetadata'][name] = value
             end
           end