Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing assembly instruction dialog causes segmentation fault #3374

Open
1 of 3 tasks
Ty3r0X opened this issue Sep 12, 2024 · 3 comments
Open
1 of 3 tasks

Editing assembly instruction dialog causes segmentation fault #3374

Ty3r0X opened this issue Sep 12, 2024 · 3 comments

Comments

@Ty3r0X
Copy link

Ty3r0X commented Sep 12, 2024

Environment information

  • Operating System: arch
  • Cutter version: 2.3.4-makepkg-209c26b
  • Obtained from:
    • Built from source
    • Downloaded release from Cutter website or GitHub
    • Distribution repository
  • File format: pe64
  • Arch: x86
  • Type: DLL (Dynamic Link Library)

Describe the bug

If I try to modify an assembly instruction using right click->Edit->Instruction I am greeted with the dialog prompting me to enter the new instruction. After pressing any key inside the text box, the program causes a segmentation fault without any warning.

To Reproduce

Steps to reproduce the behavior:

  1. Go to a function
  2. Go to Graph
  3. Select an assembly instruction
  4. Right click
  5. Click on edit
  6. Click instruction
  7. When prompted to type the new instruction, try modifying the instruction itself, not the argument
  8. crash

Expected behavior

Properly change the assembly instruction

Screenshots

bug

Additional context

➜  ~ cutter /home/ty3r0x/projects/bios-rveng/wifi.bin 
"0.7.3" "0.7.3"
Plugins are loaded from "/home/ty3r0x/.local/share/rizin/cutter/plugins"
Native plugins are loaded from "/home/ty3r0x/.local/share/rizin/cutter/plugins/native"
Python plugins are loaded from "/home/ty3r0x/.local/share/rizin/cutter/plugins/python"
Loaded 0 plugin(s).
Plugins are loaded from "/usr/local/share/rizin/cutter/plugins"
Plugins are loaded from "/usr/share/rizin/cutter/plugins"
Native plugins are loaded from "/usr/share/rizin/cutter/plugins/native"
Loaded 1 plugin(s).
[x] Analyze all flags starting with sym. and entry0 (aa)
[x] Analyze function calls
[x] Analyze len bytes of instructions for references
[x] Check for classes
[x] Analyze local variables and arguments
[x] Type matching analysis for all functions
[x] Applied 0 FLIRT signatures via sigdb
[x] Propagate noreturn information
[x] Integrate dwarf function information.
[x] Resolve pointers to data sections
[x] Use -AA or aaaa to perform additional experimental analysis.
[1]    206376 segmentation fault (core dumped)  cutter /home/ty3r0x/projects/bios-rveng/wifi.bin
@wargio
Copy link
Member

wargio commented Sep 12, 2024

can you repro this with any binary?
Please also try the AppImage just in case.

@Ty3r0X
Copy link
Author

Ty3r0X commented Sep 12, 2024

can you repro this with any binary? Please also try the AppImage just in case.

The issue occours on any kind of binary, however the appimage version does not have this issue, I can change the instruction no problem. Does that mean this issue is the responsability of the package maintainer?

@wargio
Copy link
Member

wargio commented Sep 12, 2024

it might be.
unfortunately is hard to say without a crash dump.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants