Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark available flags and available comments in hexdump #1471

Closed
Maijin opened this issue Apr 19, 2019 · 4 comments · Fixed by #2116
Closed

Mark available flags and available comments in hexdump #1471

Maijin opened this issue Apr 19, 2019 · 4 comments · Fixed by #2116
Labels
Enhancement Label requests for new features or to improve existing ones UI

Comments

@Maijin
Copy link
Member

Maijin commented Apr 19, 2019 •
edited
Loading

Is your feature request related to a problem? Please describe.

To ease navigation and provide user with all the information available in the hexdump

Describe the solution you'd like

Mark available flags and available comments in hexdump, this should be optional.
@Maijin Maijin added Enhancement Label requests for new features or to improve existing ones UI labels Apr 19, 2019
@dhavalpur0hit
Copy link
Contributor

Hi, I would like to take this up. Can you please elaborate a bit on what is expected in terms of the design? How it should look like?

@karliss
Copy link
Member

karliss commented Mar 19, 2020

I can think of two approaches this could be done.

One is to use the mechanism suggested in https://github.com/radareorg/cutter/issues/1945#issuecomment-598440589 . Indicate the position of comment or flag using little marker in the hex section and display the flag name or comment text as tooltip when hovering the marker.

Other is to add a column and display text there.

dhavalpur0hit added a commit to dhavalpur0hit/cutter that referenced this issue Mar 22, 2020
@dhavalpur0hit
Mark available flags and comments (rizinorg#1471)
57bc3d5
dhavalpur0hit added a commit to dhavalpur0hit/cutter that referenced this issue Mar 23, 2020
@dhavalpur0hit
Show available flags and comments in hexdump (rizinorg#1471)
9990b00
dhavalpur0hit added a commit to dhavalpur0hit/cutter that referenced this issue Mar 23, 2020
@dhavalpur0hit
Show available flags and comments in hexdump (rizinorg#1471)
a500bff
@dhavalpur0hit dhavalpur0hit mentioned this issue Mar 23, 2020
Closed
3 tasks
@karliss
Copy link
Member

karliss commented Mar 23, 2020

Here is an example for how the additional column approach could look.
photo_2020-03-23_15-53-15

@dhavalpur0hit
Copy link
Contributor

Thanks, got it. I'll change the design implementation.

dhavalpur0hit added a commit to dhavalpur0hit/cutter that referenced this issue Mar 28, 2020
@dhavalpur0hit
Add tooltip for displaying flag and comment in hexdump (rizinorg#1471)
08867b7
@dhavalpur0hit dhavalpur0hit mentioned this issue Mar 28, 2020
Merged
3 tasks
ITAYC0HEN added a commit that referenced this issue Apr 4, 2020
@dhavalpur0hit @ITAYC0HEN @karliss
Add tooltip for displaying flag and comment in hexdump (#1471) (#2116)
7110d73 
* Add tooltip for displaying flag and comment in hexdump (#1471)


Co-authored-by: Itay Cohen <[email protected]>
Co-authored-by: karliss <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement Label requests for new features or to improve existing ones UI
Projects
None yet
Milestone
No milestone
3 participants
@Maijin @karliss @dhavalpur0hit