Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

panic when getting worker parallelism for non CN nodes #19785

Open
xxchan opened this issue Dec 12, 2024 · 2 comments
Open

panic when getting worker parallelism for non CN nodes #19785

xxchan opened this issue Dec 12, 2024 · 2 comments
Assignees
Milestone

Comments

@xxchan
Copy link
Member

xxchan commented Dec 12, 2024

          This will panic in some places:
  • diagnose in dashboard
  • show cluster

Can you examine the usages of worker.parallelism()? (Or you may change list_all_nodes() calls to list_cn())

Originally posted by @xxchan in #19153 (comment)

@shanicky
Copy link
Contributor

The previous design only considered parallelism for compute nodes, so an assertion was made. Is it possible to determine the type of the server before making a call?

@xxchan
Copy link
Member Author

xxchan commented Dec 18, 2024

e.g., ListAllNodesRequest contains a worker_type parameter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants