Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add system column rw_timestamp for any tables #11629

Open
fuyufjh opened this issue Aug 11, 2023 · 5 comments · May be fixed by #19232
Open

Add system column rw_timestamp for any tables #11629

fuyufjh opened this issue Aug 11, 2023 · 5 comments · May be fixed by #19232
Assignees
@chenzl25
Labels
type/feature
Milestone
release-2.2

Comments

@fuyufjh
Copy link
Member

fuyufjh commented Aug 11, 2023 •
edited
Loading

Is your feature request related to a problem? Please describe.

Expose rw_timestamp on any tables.

Because our subscription already exposed a timestamp rw_timestamp based on epoch, I think there isn’t any concern about exposing the internal epoch using a hidden column.

Besides, I think vnode and epoch is also useful in some cases. How about do them together?

Describe the solution you'd like

No response

Describe alternatives you've considered

No response

Additional context

Slack discussion https://risingwave-labs.slack.com/archives/C048771BGKF/p1691737477347599?thread_ts=1691732764.258889&cid=C048771BGKF
@github-actions github-actions bot added this to the release-1.2 milestone Aug 11, 2023
@TennyZhuang TennyZhuang self-assigned this Aug 14, 2023
@TennyZhuang TennyZhuang modified the milestones: release-1.2, release-1.3 Sep 11, 2023
@TennyZhuang TennyZhuang modified the milestones: release-1.3, release-1.4 Oct 10, 2023
@TennyZhuang TennyZhuang modified the milestones: release-1.4, release-1.5 Nov 8, 2023
@st1page st1page self-assigned this Nov 27, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 1, 2024

This issue has been open for 60 days with no activity.

If you think it is still relevant today, and needs to be done in the near future, you can comment to update the status, or just manually remove the no-issue-activity label.

You can also confidently close this issue as not planned to keep our backlog clean.
Don't worry if you think the issue is still valuable to continue in the future.
It's searchable and can be reopened when it's time. 😄

@st1page
Copy link
Contributor

st1page commented Aug 15, 2024

Some additions: they can only be referenced by a batch query and not by a streaming query.

@fuyufjh fuyufjh assigned chenzl25 and unassigned TennyZhuang and st1page Aug 15, 2024
@chenzl25
Copy link
Contributor

_rw_epoch and _rw_vnode look reasonable. However, do we need _rw_raw_value and _rw_raw_key?

@fuyufjh
Copy link
Member Author

fuyufjh commented Aug 19, 2024

_rw_epoch and _rw_vnode look reasonable. However, do we need _rw_raw_value and _rw_raw_key?

Sorry, please ignore them. Let's start from rw_timestamp now. Please check this Slack thread for context.

@st1page
Copy link
Contributor

st1page commented Aug 23, 2024

_rw_epoch and _rw_vnode look reasonable. However, do we need _rw_raw_value and _rw_raw_key?

The requirements come from the debugging and trouble shooting for the tricky bugs such as https://risingwave-labs.slack.com/archives/C048771BGKF/p1691736276987669?thread_ts=1691732764.258889&cid=C048771BGKF

@fuyufjh fuyufjh changed the title Add some system columns for any tables Add system column rw_timestamp for any tables Oct 30, 2024
@chenzl25 chenzl25 linked a pull request Nov 1, 2024 that will close this issue
Open
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chenzl25 chenzl25

Labels
type/feature
Projects
None yet
Milestone
release-2.2
Development

Successfully merging a pull request may close this issue.

feat(batch): support system column _rw_timestamp for tables risingwavelabs/risingwave
5 participants
@lmatz @TennyZhuang @chenzl25 @fuyufjh @st1page