Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fallback property in development mode #23

Open
selipso opened this issue Jun 5, 2024 · 1 comment
Open

Use fallback property in development mode #23

selipso opened this issue Jun 5, 2024 · 1 comment

Comments

@selipso
Copy link

selipso commented Jun 5, 2024

I'm not sure if this happens in production builds or not, but I noticed that when developing offline using a Google Fonts url as a font, the astro compiler throws an error instead of using the fallback default sans-serif font.

Steps to reproduce:

  • turn off wi-fi / networking on your computer
  • astro dev a project that uses a google font URL in the AstroFont component
  • Compiler throws error

Expected behavior:

  • Project should compile using the default sans-serif font if network is unreachable
@rishi-raj-jain
Copy link
Owner

@selipso

That's a use case I definitely did not think of!

You're totally correct though.

Let me think of something by the weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants