Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation in erc20-counter #293

Open
Wollac opened this issue Oct 15, 2024 · 3 comments
Open

Fix deprecation in erc20-counter #293

Wollac opened this issue Oct 15, 2024 · 3 comments
Labels

Comments

@Wollac
Copy link
Contributor

Wollac commented Oct 15, 2024

The erc20-counter example currently dynamically creates either a block or a beacon commitment depending on its command line arguments. This uses the deprecated into_beacon_input:

// Finally, construct the input from the environment.
let evm_input = if let Some(beacon_api_url) = args.beacon_api_url {
    #[allow(deprecated)]
    env.into_beacon_input(beacon_api_url).await?
} else {
    env.into_input().await?
};

Instead, the intended behaviour in steel v1.1 is to use builder.beacon_api(url). However, as we are using a typed builder pattern, the following will not work as the type of the builder changes:

if let Some(beacon_api_url) = args.beacon_api_url { {
    builder = builder.beacon_api(beacon_api_url);
}
Copy link

linear bot commented Oct 15, 2024

@Wollac Wollac added the steel label Oct 15, 2024 — with Linear
@mahmudsudo
Copy link

can i take on this issue ?

@nategraf
Copy link
Contributor

@mahmudsudo, sure! This is a good first issue

@nategraf nategraf added the good first issue Good for newcomers label Oct 23, 2024
@Wollac Wollac added examples and removed steel labels Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants