Fix some "Passing null to parameter" warnings (matomo-org#19135)

* Fix "passing null to parameter" errors

* Fix "passing null to parameter" error

* Fix "passing null to parameter" errors

* Fix "passing null to parameter" error

* Update fix for "passing null to parameter" error

Co-authored-by: Michael Roosz <[email protected]>

Author: MichaelRoosz

core/Twig.php

@@ -360,6 +360,11 @@ protected function addFilter_notification()
     protected function addFilter_safeDecodeRaw()
     {
         $rawSafeDecoded = new TwigFilter('rawSafeDecoded', function ($string) {
+
+            if ($string === null) {
+                return '';
+            }
+
             $string = str_replace('+', '%2B', $string);
             $string = str_replace(' ', html_entity_decode(' ', ENT_COMPAT | ENT_HTML401, 'UTF-8'), $string);
 

libs/HTML/QuickForm2/Rule/Nonempty.php

@@ -93,7 +93,7 @@ protected function validateOwner()
         } elseif (is_array($value)) {
             return count(array_filter($value, 'strlen')) >= $this->getConfig();
         } else {
-            return (bool)strlen($value);
+            return (bool)strlen($value ?? '');
         }
     }
 

plugins/Referrers/Columns/Base.php

@@ -477,7 +477,7 @@ protected function detectCampaignKeywordFromReferrerUrl()
      */
     protected function getParameterValueFromReferrerUrl($adsenseReferrerParameter)
     {
-        $value = trim(urldecode(UrlHelper::getParameterFromQueryString($this->referrerUrlParse['query'], $adsenseReferrerParameter)));
+        $value = trim(urldecode(UrlHelper::getParameterFromQueryString($this->referrerUrlParse['query'], $adsenseReferrerParameter) ?? ''));
         return $value;
     }
 
@@ -522,7 +522,7 @@ protected function detectReferrerCampaign(Request $request, Visitor $visitor)
             return false;
         }
 
-        $this->keywordReferrerAnalyzed = mb_strtolower($this->keywordReferrerAnalyzed);
+        $this->keywordReferrerAnalyzed = mb_strtolower($this->keywordReferrerAnalyzed ?? '');
         $this->nameReferrerAnalyzed = mb_strtolower($this->nameReferrerAnalyzed);
         return true;
     }

plugins/UsersManager/Model.php

@@ -207,7 +207,7 @@ public function getSitesAccessFromUserWithFilters($userLogin, $limit = null, $of
 
         $access = $db->fetchAll($sql, $bind);
         foreach ($access as &$entry) {
-            $entry['access'] = explode('|', $entry['access']);
+            $entry['access'] = explode('|', $entry['access'] ?? '');
         }
 
         $count = $db->fetchOne("SELECT FOUND_ROWS()");
@@ -659,7 +659,7 @@ public function getUsersWithRole($idSite, $limit = null, $offset = null, $patter
 
         $users = $db->fetchAll($sql, $bind);
         foreach ($users as &$user) {
-            $user['access'] = explode('|', $user['access']);
+            $user['access'] = explode('|', $user['access'] ?? '');
         }
 
         $count = $db->fetchOne("SELECT FOUND_ROWS()");