Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider better implementation for chains #6

Open
rigdern opened this issue Oct 12, 2023 · 0 comments
Open

Consider better implementation for chains #6

rigdern opened this issue Oct 12, 2023 · 0 comments

Comments

@rigdern
Copy link
Owner

rigdern commented Oct 12, 2023

I went with the most straightforward implementation. It just omits any chains that don't fully fit into the song slice.

Improvement ideas:

  • If a chain doesn't fully fit into a slice, it could be truncated to the portion that does fit into the slice. Would this benefit be worth the implementation cost?

  • Whenever we omit a SliderData that represents a chain (i.e. its sliderType is Burst) then we should also omit the item representing the head of the chain (the head of the chain is a NoteData with type: BurstSliderHead).

    For now, we leave the head of the chain alone because it results in the simplest implementation. Leaving it in doesn't result in any undesirable side effects in the game, as far as I know.

    A good question is: is there any noticeable impact of our current implementation of omitting the SliderData but not NoteData, type: BurstSliderHead? If not, perhaps it’s not worth the implementation cost of doing anything fancier than we’re currently doing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant