Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading help text for the "protected" checkbox #523

Open
palant opened this issue Jun 25, 2015 · 3 comments
Open

Misleading help text for the "protected" checkbox #523

palant opened this issue Jun 25, 2015 · 3 comments

Comments

@palant
Copy link

palant commented Jun 25, 2015

When editing an issue, there is the following text under the "protected" checkbox:

Only viewable by @chromium and @google accounts.

As far as I can judge, this is completely bogus. It should be rather "Only viewable to owner and people listed in CC and Reviewers fields."

For reference, the code in question is in codereview/views.py:

  private = forms.BooleanField(
    required=False, initial=False, label='Protected',
    help_text=(
      'Only viewable by @chromium and @google accounts.'
      '<div class="if_checked">'
      'Please, avoid mailing lists in the CC and Reviewers fields.'
      '</div>'))
@palant
Copy link
Author

palant commented Jun 25, 2015

The issue was introduced by this commit: b761f8c

@zhtw12345
Copy link

不能用……欠人幹怎麼辦

@zhtw12345
Copy link

你玩你的,我玩我的
Uploading IMAG0215(5).jpg…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants