Skip to content

Commit dfe184f

Browse files
committed
Passing URL as environment variable
Signed-off-by: Lukas Bednar <[email protected]>
1 parent ae7b8ac commit dfe184f

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

README.rst

+2-2
Original file line numberDiff line numberDiff line change
@@ -198,11 +198,11 @@ Usage
198198
# connection_error_strategy [strict|skip|ignore] Choose how to handle connection errors
199199
# return_jira_metadata = False (return Jira issue with metadata instead of boolean result)
200200
201-
You can set the password and username fields by setting the PYTEST_JIRA_PASSWORD, PYTEST_JIRA_USERNAME and
202-
PYTEST_JIRA_TOKEN environment variables:
201+
Alternatively, you can set the url, password, username and token fields using relevant environment variables:
203202

204203
.. code:: sh
205204
205+
export PYTEST_JIRA_URL="https://..."
206206
export PYTEST_JIRA_PASSWORD="FOO"
207207
export PYTEST_JIRA_USERNAME="BAR"
208208
export PYTEST_JIRA_TOKEN="TOKEN"

pytest_jira.py

+5-2
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929
SKIP = 'skip'
3030
IGNORE = 'ignore'
3131
PLUGIN_NAME = "jira_plugin"
32+
URL_ENV_VAR = 'PYTEST_JIRA_URL'
3233
PASSWORD_ENV_VAR = 'PYTEST_JIRA_PASSWORD'
3334
USERNAME_ENV_VAR = 'PYTEST_JIRA_USERNAME'
3435
TOKEN_ENV_VAR = 'PYTEST_JIRA_TOKEN'
@@ -544,9 +545,11 @@ def pytest_configure(config):
544545
if not resolved_resolutions:
545546
resolved_resolutions = []
546547

547-
if config.getvalue('jira') and config.getvalue('jira_url'):
548+
if config.getvalue('jira') and (
549+
os.getenv(URL_ENV_VAR) or config.getvalue('jira_url')
550+
):
548551
jira_connection = JiraSiteConnection(
549-
config.getvalue('jira_url'),
552+
os.getenv(URL_ENV_VAR) or config.getvalue('jira_url'),
550553
os.getenv(USERNAME_ENV_VAR) or config.getvalue('jira_username'),
551554
os.getenv(PASSWORD_ENV_VAR) or config.getvalue('jira_password'),
552555
config.getvalue('jira_verify'),

0 commit comments

Comments
 (0)