CPU/memory utilization improvements using d3.timer
#126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 24, 2015 15:14
…use detected native browser features for reduced and more efficient painting
|
@dalanmiller: great call, I was unaware that D3 has its own timer system. |
|
|
||
| d3.timer(createNextFunction(), update_freq+200); | ||
|
|
||
| # setInterval () -> |
There was a problem hiding this comment.
Should this still be commented out?
|
Ready for merge if no further comments |
| # Bump up the score cap | ||
| score_cap = score_cap + 1 | ||
|
|
||
| if ret == false |
There was a problem hiding this comment.
Since this is CoffeeScript: if ret is false
|
👍 |
|
Since everything is now in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/mbostock/d3/wiki/Transitions#timers
Removed the
setIntervalfunctions fromlanding.coffeeand replaced them with the more efficient D3 timer. Anecdotal evidence on my machine seems that things are a bit better.I think this will improve #71
@danielmewes