Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scrot --select and DPI #285

Open
guijan opened this issue May 4, 2023 · 5 comments
Open

scrot --select and DPI #285

guijan opened this issue May 4, 2023 · 5 comments
Labels
enhancement New feature or request

Comments

@guijan
Copy link
Contributor

guijan commented May 4, 2023

Here's a worst case scenario: you have a smartphone with a 4k screen running PostMarketOS. You take a screenshot with scrot -s and... the selection border is 1 pixel wide. That's microscopic.

The default selection border size should scale with DPI. Currently, the user can manually specify a size, but a program should do its best to have some sensible behavior by default rather than requiring customization to work.
@N-R-K N-R-K added the enhancement New feature or request label May 24, 2023
@N-R-K
Copy link
Collaborator

N-R-K commented Jun 30, 2023

Do you have any formula in mind to calculate what the border size should be?

@guijan
Copy link
Contributor Author

guijan commented Jun 30, 2023

dpi / 75 + 1 should be fine.

@N-R-K
Copy link
Collaborator

N-R-K commented Jul 2, 2023

Do you know a way to get the DPI from X? I did some quick search on it a while ago and didn't find anything straightforward (though admittedly, I didn't search too much).

If you know how to do it then feel free to open a PR - the formula seems ok to me.

@guijan
Copy link
Contributor Author

guijan commented Jul 5, 2023

No, sorry. I'm reading instead of programming at the moment.

N-R-K added a commit that referenced this issue Jan 30, 2025
@N-R-K
WIP: derive default selection width from display dpi
e923fbe 
Closes: #285
@N-R-K
Copy link
Collaborator

N-R-K commented Jan 30, 2025

dpi / 75 + 1 should be fine.

I went with round(dpi / 75.0) and then clamping the result to [1, 8] to be consistent with the cli limit of -l width.

N-R-K added a commit that referenced this issue Jan 30, 2025
@N-R-K
derive default line width from display dpi
ca33dbf 
allows better default on high dpi displays where the previous
default of 1 pixel would've been too small.

Closes: #285
N-R-K added a commit that referenced this issue Jan 30, 2025
@N-R-K
derive default line width from display dpi
bd0ffe6 
allows better default on high dpi displays where the previous
default of 1 pixel would've been too small.

Closes: #285
N-R-K added a commit that referenced this issue Feb 11, 2025
@N-R-K @guijan
derive default line width from display dpi
2530de5 
allows better default on high dpi displays where the previous
default of 1 pixel would've been too small.

Closes: #285
Co-authored-by: Guilherme Janczak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@guijan @N-R-K