Debug logging around Ingress PP node routing and partition refreshes #2224
+30
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcholakov
force-pushed
the
test/partition-routing-refresh-logging
branch
from
a17f33a
to
f8a45d3
Compare
pcholakov
force-pushed
the
test/partition-routing-refresh-logging
branch
from
f8a45d3
to
9a1b4cb
Compare
| let result: Result<Option<SchedulingPlan>, _> = | ||
| metadata_store_client.get(SCHEDULING_PLAN_KEY.clone()).await; | ||
|
|
||
| let Ok(scheduling_plan) = result else { | ||
| debug!( | ||
| warn!( |
There was a problem hiding this comment.
Not sure if this should be warn TBH, because it gets retried, right?
There was a problem hiding this comment.
Retired?
I think it's a bad situation that the operator should know about; if we can't fetch or refresh the plan, routing decisions will be failing and things will look very odd.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional trace-level logging for some cases that might help for troubleshooting partition routing; increase log level to warn for error cases to highlight that nodes might be operating with stale information.