Disable updateRestateDependency task on CI #251
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slinkydeveloper
force-pushed
the
fix-e2e-script
branch
from
b2ca310
to
292b6f9
Compare
There was a problem hiding this comment.
Thanks for creating this PR @slinkydeveloper. Before merging it, I would like to understand why updating an dependency after running a fresh install operation leads to a problem. If the latest dependency version was installed then updating it should result into the same dependency version. If install installed an outdated version, then updating it should run it with the latest version.
Comment on lines
+33
to
35
| // On CI we don't need to update the restate dependency, this is done implicitly by the e2e | ||
| // workflow. | ||
| dependsOn("updateRestateDependency") |
There was a problem hiding this comment.
What I would like to understand is how does updating the restate-sdk dependency lead to a problem after a fresh install?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix 082e023#r137148028 and 082e023#r137148028
What's happening in that test script is that we run
npm install <tar>from the workflow file first, and thennpm updatefrom the gradle script, which overwrites the sdk. This seems incorrect.