Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeat footer on both panels #1832

Open
damithc opened this issue Aug 30, 2022 · 2 comments
Open

Repeat footer on both panels #1832

damithc opened this issue Aug 30, 2022 · 2 comments

Comments

@damithc
Copy link
Collaborator

damithc commented Aug 30, 2022

It's a bit odd that this footer appears on one panel only.
image

Should we repeat it on both sides?

Other suggestions welcome.

@jedkohjk
Copy link
Contributor

I think duplicating the footer might look odd too. I've made a pull request to shift the timestamp up (so neither panel has a footer). Since it now becomes close to the title, I also updated the timestamp message to make it clear that it is not part of the title. You can see my pull request (#2241 ) for the screenshots.

I've also created a separate issue (#2240 ) because I found the datetime format strange. It is not due to my changes.

@jedkohjk
Copy link
Contributor

jedkohjk commented Aug 13, 2024

Made (and closed) 2 suggestions for this issue: #2241 and #2243

Summary of discussions:

  • Duplicating the footer on both sides may not look very nice either
  • The timestamp and link to most recent commit were intended for debugging - they should remain relatively inconspicuous to users
  • It may be useful to make the link to the user guide more visible to users such as in @damithc 's comment on #2243. Currently, the user guide is only seen when the right panel is showing a welcome message, which does not reappear after users view a code panel or commits panel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Tasks on hold
3 participants