Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

when using agent-js-webdriverio, finishLaunch doesn't seem to update the launch to finish #47

Closed
HananArgov opened this issue Jun 26, 2023 · 2 comments · Fixed by #39
Closed

when using agent-js-webdriverio, finishLaunch doesn't seem to update the launch to finish #47

HananArgov opened this issue Jun 26, 2023 · 2 comments · Fixed by #39
Labels
bug Something isn't working
Milestone
5.1.0

Comments

@HananArgov
Copy link

i've been using agent-js-webdriverio latest with wdio 8.10.0 and from what i'm seeing, the promise isn't fuilly resolved at the line below

https://github.com/reportportal/client-javascript/blob/0cae739a94cda024c98d01064d08c380664703a0/lib/report-portal-client.js#L242C29-L242C29

the run seem to end right after the log shows:

Finish launch with tempId sktwiueoljcvl2xg { endTime: 1687784983869 }
@AmsterGet
Copy link
Member

Hello @HananArgov !
Could you please provide more details on it?
What is expected behavior?

@AmsterGet AmsterGet transferred this issue from reportportal/client-javascript Sep 12, 2023
@AmsterGet AmsterGet mentioned this issue Jan 19, 2024
Merged
@AmsterGet AmsterGet added this to the 5.1.0 milestone Feb 2, 2024
@AmsterGet AmsterGet added the bug Something isn't working label Feb 2, 2024
@AmsterGet AmsterGet mentioned this issue Feb 2, 2024
Closed
@AmsterGet
Copy link
Member

Fixed in version 5.1.0.

@AmsterGet AmsterGet linked a pull request Feb 6, 2024 that will close this issue
Release 5.1.0 #39
Merged
@amalbaccar-hub amalbaccar-hub mentioned this issue Feb 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
5.1.0
Development

Successfully merging a pull request may close this issue.

Release 5.1.0 reportportal/agent-js-webdriverio
2 participants
@AmsterGet @HananArgov