Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon deprecation system #572

Open
asportnoy opened this issue Oct 14, 2023 · 1 comment
Open

Addon deprecation system #572

asportnoy opened this issue Oct 14, 2023 · 1 comment
Labels
available (leave comment to claim) If you're interested in taking on this issue, please leave a comment! enhancement New feature or request

Comments

@asportnoy
Copy link
Member

We need some kind of system for being able to mark an addon as deprecated. There have been a couple cases already where we want to deprecate one addon in favor of another, but there is currently no way to do that. We'd add a key to the manifest like this:

{
    "deprecated": {
        "message": "Message to explain the deprecation",
        "replacement": {
            "id": "Updater info for recommending a replacement",
            "source": "store"
        }
    }
}

Both keys within are optional, and we'll allow devs to simply specify deprecated: true if they don't want to specify either.

In the updater, we'd display that the addon is deprecated along with the dev's message if specified. If a replacement is specified, we'd show a button to switch to that addon instead (show the regular install flow modal, and if the user approves the install, uninstall the existing addon). It will also show an uninstall button. No update button will be shown.

If a user tries to install a deprecated addon, we'd show a modal with the same information and buttons. Users will not be able to install deprecated addons.

In the store, we'd hide the addon from the list and from search. If the page is viewed directly, we'd display the deprecation notice with a link to the replacement if applicable. (This will be done later outside of this PR)

@asportnoy asportnoy added enhancement New feature or request available (leave comment to claim) If you're interested in taking on this issue, please leave a comment! labels Oct 14, 2023
@ShadiestGoat
Copy link
Contributor

I can take this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
available (leave comment to claim) If you're interested in taking on this issue, please leave a comment! enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants