Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with python 3.7? #7

Open
nbroad1881 opened this issue Nov 30, 2021 · 7 comments
Open

Compatibility with python 3.7? #7

nbroad1881 opened this issue Nov 30, 2021 · 7 comments

Comments

@nbroad1881
Copy link

I'm wondering what makes it incompatible with python 3.7 because that is the python version I am using and I can't upgrade to 3.8

@rentruewang
Copy link
Owner

Personally I use the walrus operator := a lot and it's only supported in 3.8 or above. I guess I just didn't use 3.7 on local when developing this project.

However, supporting 3.7 would be a great idea, as PyTorch itself supports 3.6, 3.7, 3.8. So I'll be working on it when I've got time.

@nbroad1881
Copy link
Author

Is there anything besides the walrus operator that makes it incompatible with 3.7?

@rentruewang
Copy link
Owner

rentruewang commented Nov 30, 2021

There is a @final decorator that isn't available in 3.7. Other than that and walrus operator, it should be compatible with 3.7.

@nbroad1881
Copy link
Author

Protocol in typing is also 3.8

@rentruewang
Copy link
Owner

rentruewang commented Dec 1, 2021

Oh, I didn't know that. Thanks!

@nielsrolf
Copy link

This would be great - colab also runs on Python 3.7 and I could imagine that many people would like to use koila there

@lukeleeai
Copy link

lukeleeai commented Dec 20, 2021

I agree. As who use colab / kaggle notebooks, it's sad that I can't use Koila cuz they use Python 3.7 :( Making it compatible with 3.7 would potentially have more people use your package. I just posted the issue that pip can't find Koila on colab / kaggle, but is it because of the version incompatibility?

Repository owner deleted a comment Dec 26, 2023
Repository owner deleted a comment Jan 1, 2024
Repository owner deleted a comment from tobarbaro Jan 1, 2024
Repository owner locked and limited conversation to collaborators Jan 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants
@nielsrolf @lukeleeai @nbroad1881 @rentruewang and others