Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support *.MODULE.bazel pattern #31918

Open
rarkins opened this issue Oct 11, 2024 Discussed in #31916 · 1 comment
Open

Support *.MODULE.bazel pattern #31918

rarkins opened this issue Oct 11, 2024 Discussed in #31916 · 1 comment
Assignees
Labels
good first issue Suitable for new contributors manager:bazel Bazel WORKSPACE files priority-4-low Low priority, unlikely to be done unless it becomes important to more people type:feature Feature (new functionality)

Comments

@rarkins
Copy link
Collaborator

rarkins commented Oct 11, 2024

Discussed in #31916

Originally posted by daniel-b2c2 October 11, 2024

Tell us more.

[In the context of Bazel support]

Renovate supports MODULE.bazel pattern but treats it as an exact file, rather than a suffix, and so does not support *.MODULE.bazel

While it's common for most projects to start with a single bazel module file MODULE.bazel, larger monorepos often refactor and segregate this file into sub-modules, blah.MODULE.bazel.

Renovate debug logs show a file search for the pattern (^|/)MODULE.bazel$ which is too strict but could be modified to support blah.MODULE.bazel

Minimum demonstration project showing how renovate currently doesn't support this: https://github.com/daniel-b2c2/bazel-module-issue

Proof that I'm not just making this up MODULE.bazel is a suffix and so *.MODULE.bazel is permitted: https://github.com/bazelbuild/bazel/pull/22075/files

We've been using renovate for a while, but since we've had to refactor the MODULE.bazel file, we're no longer receiving pull requests as the subfile are not detected as bazel modules.

Many thanks for considering this extension.

@rarkins rarkins added type:feature Feature (new functionality) priority-4-low Low priority, unlikely to be done unless it becomes important to more people manager:bazel Bazel WORKSPACE files good first issue Suitable for new contributors labels Oct 11, 2024
@anupamney

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Suitable for new contributors manager:bazel Bazel WORKSPACE files priority-4-low Low priority, unlikely to be done unless it becomes important to more people type:feature Feature (new functionality)
Projects
None yet
Development

No branches or pull requests

2 participants