Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secrets in onboardingConfig should not be resolved #30992

Open
rarkins opened this issue Aug 24, 2024 · 0 comments
Open

Secrets in onboardingConfig should not be resolved #30992

rarkins opened this issue Aug 24, 2024 · 0 comments
Labels
breaking Breaking change, requires major version bump core:config Related to config capabilities and presets core:onboarding Related to the onboarding process priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:bug Bug fix of existing functionality

Comments

@rarkins
Copy link
Collaborator

rarkins commented Aug 24, 2024

Describe the proposed change(s).

Ref: #30837

The challenge here is that it's possible that some handlebars templates in onboardingConfig should be resolved, while some not.

I think a quick way to resolve this in a major release would be to add new config option onboardingConfigCompilation which defaults to false. If true, the current behavior will occur, and users should not opt into it if they include secrets in templates. Otherwise onboardingConfig compilation should be skipped.

@rarkins rarkins added type:bug Bug fix of existing functionality priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others breaking Breaking change, requires major version bump core:onboarding Related to the onboarding process core:config Related to config capabilities and presets labels Aug 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change, requires major version bump core:config Related to config capabilities and presets core:onboarding Related to the onboarding process priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:bug Bug fix of existing functionality
Projects
None yet
Development

No branches or pull requests

1 participant