Add a timeout to chunked upload requests, so it tries again.

[Piero512]

Hello

I was looking into this fileserver and it's very featured. I like the out of box experience.

My suggestion is to attach a timeout for the put requests used to upload files, so we can try it again later, instead of getting the upload just hang.

Notice in devtools that thre is a hanging request, which I think CF just made it, but the client code doesn't seem to try cancelling the request if it takes too long and just reissuing it.

[rejetto]

hi Piero!
how many times did you see this problem?
is there a way for me to reproduce this problem?
how long did you wait to determine the request is stuck?
and what's exactly the rule you suggest to implement? is it upload speed zero? for how long?

[Piero512]

I can reproduce it consistently, by trying to upload that 4GB file when running the server on Windows 10/Windows Server 2019 standard edition, through CF reverse proxy. from another computer from Europe (I use those database backups to diagnose problems and decided that I did not wanted to upload those DBs to an external service).

I literally have tried this whole day to get it to work. so the wait was more than 5 minutes, and you can see the chunks on the screenshot took way less. Tried experimenting with different chunk sizes since it was recommended to set it to 100mb for CF free.

Probably the easiest way to try it would be to try and run an instance in any supported device, run cloudflared to run the service, and try uploading a huge file.

I wish it would be less of a fight to just request a port forward in the place I run the server (my job).

TBH, I don't know what would be a good rule. Have you ever heard of The Upload Server protocol? I hope they have solved the issue already. It has different backends, so maybe it can be plugged in on the VFS that HFS builds for the client?

[rejetto]

i didn't know about this TUS project. Sounds interesting, but nothing i can consider in the immediate moment.
from your screeshot, i understand some chunks are correctly uploaded, but at some point it stops.
i guess you don't know if it stops in the middle of a chunk, or at the very start of it.
i know there are other CF users who never reported any problem with uploads this big. I wonder what's different with your case.

1. Your suggestion to cancel and reattempt makes sense, but we don't know if that would actually work, right?
2. What happens if you stop the upload (even with a brutal reload of the page), and attempt another upload? It should offer you to resume. Does it progress this way? Does it stop after some more chunks?

[Piero512]

The resume functionality is not stable enough, ie, it fails when the chunk size is low, as it assumes that you didn't want to resume and it's also manual. Maybe the resume functionality should check before issuing the upload request if you want to resume, instead of doing it with the pop-up while uploading

[rejetto]

the reason why it uploads while waiting for the user to answer the dialog, is to allow long unattended uploads without stopping.

Yes, i see that it is not handled correctly if the second chunk starts before the user has answered the resume-confirmation-dialog. Thanks for pointing that out. I will work on that.

[rejetto]

i both fixed the resume bug (hopefully), and implemented a retry mechanism in case the upload is stuck.
i made my tests by simulating the hanging (twice in a row). I can't test with CF at the moment.
would you be available to make a test?
i can give you a previous version
https://github.com/user-attachments/files/18291455/hfs-windows-x64-0.55.2-beta1.zip
you can easily install it by right-clicking on "check for updates" in admin-panel/home.

[Piero512]

Hmm, I would be able to try the exact setup when the new year holiday ends in my country, on January 6th.

Probably today in the afternoon I could try the build in my personal computers.

[rejetto]

if you didn't yet, use this
https://github.com/user-attachments/files/18293786/hfs-windows-x64-0.55.2-beta2.zip
as it includes more fixes

[rejetto]

you don't need to right-click anymore.
Just normal click, after enabling the "include beta versions" option.