Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debug logging #19

Open
reibitto opened this issue Apr 10, 2021 · 0 comments
Open

Add debug logging #19

reibitto opened this issue Apr 10, 2021 · 0 comments

Comments

@reibitto
Copy link
Owner

There are a few temporary println statements in the code which I'll be removing before the first release. Eventually I'd like to add proper debug logging into this library. The thing is, it's bad form for a library to log by default or force a logging library dependency.

I think I'd prefer to go with the approach Gabriel suggested here:
https://twitter.com/volpegabriel87/status/1377490991746330631

The idea is to create a Logger typeclass and add instances for various logging libraries. And the default should be set to a NoOpLogger.

It's more work for us, but it's a better experience for the user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant