some logger fixes

Author: scopatz

rever/logger.xsh

@@ -33,6 +33,7 @@ class Logger:
             entry['activity'] = activity
         with open(self.filename, 'a+') as f:
             json.dump(entry, f, sort_keys=True, separators=(',', ':'))
+            f.write('\n')
 
     def load(self):
         """Loads all of the records from the logfile and returns a list of dicts."""

tests/conftest.py

@@ -10,7 +10,9 @@
 
 @pytest.fixture
 def gitrepo(request):
-    """A test fixutre that creates and destroys a git repo in a temporary directory"""
+    """A test fixutre that creates and destroys a git repo in a temporary directory.
+    This will yeild the path to the repo.
+    """
     cwd = os.getcwd()
     name = request.node.name
     repo = os.path.join(tempfile.gettempdir(), name)

tests/test_logger.py

@@ -1,11 +1,24 @@
 """Tests logger"""
 import os
 
+from rever import vcsutils
 from rever.logger import Logger
 
 
 def test_logger(gitrepo):
     logger = Logger(os.path.join(gitrepo, 'mylog.json'))
     logger.log('sample message', activity="kenny", category="loggin'")
+    logger.log('another message', activity="wood", category="chippin'")
     entries = logger.load()
-    assert len(entries) == 1
+    assert len(entries) == 2
+    entry = entries[0]
+    assert entry['message'] == 'sample message'
+    assert entry['activity'] == 'kenny'
+    assert entry['category'] == "loggin'"
+    assert entry['rev'] == vcsutils.current_rev()
+    entry = entries[1]
+    assert entry['message'] == 'another message'
+    assert entry['activity'] == 'wood'
+    assert entry['category'] == "chippin'"
+    assert entry['rev'] == vcsutils.current_rev()
+    assert entries[0]['timestamp'] < entries[1]['timestamp']