Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub allows single character usernames and usernames with multiple instances of single hyphens #7

Open
dguo opened this issue Mar 2, 2018 · 0 comments
Open

GitHub allows single character usernames and usernames with multiple instances of single hyphens #7

dguo opened this issue Mar 2, 2018 · 0 comments

Comments

@dguo
Copy link
Contributor

dguo commented Mar 2, 2018 •
edited
Loading

If you put foo-foo-foo into the username field on the homepage, it's allowed. But this regex will return false for it.

This regex also blocks single character usernames, which aren't prohibited by the specified rules.
@dguo dguo changed the title GitHub allows multiple instances of single hyphens GitHub allows multiple instances of single hyphens and single character usernames Mar 3, 2018
@dguo dguo changed the title GitHub allows multiple instances of single hyphens and single character usernames GitHub allows single character usernames and usernaes with multiple instances of single hyphens Mar 3, 2018
@dguo dguo changed the title GitHub allows single character usernames and usernaes with multiple instances of single hyphens GitHub allows single character usernames and usernames with multiple instances of single hyphens Mar 3, 2018
@dguo dguo mentioned this issue Mar 3, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dguo