Memoize Apollo Client #11699
Open
Memoize Apollo Client #11699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
Thanks for the PR @justinadkins! I'll assign it to @callingmedic911 as he interacted with you on the issue you filed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11602.
This PR adds memoization around the Apollo Client and its dependencies to prevent new clients being instantiated each time the provider is re-rendered. The only time a client will reinstantiate now is when the configuration has been modified.
If a client is reinstantiated, the previous client is now stopped to prevent a potential memory leak.
Note: The links that the client uses right now are unstable and were purposefully left out of the dependency array. Making links stable will require more effort that may not be necessary since the solution provided still updates them in a
useEffect.