Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redux-React Basic Tutorial issues #1684

Open
cniemann88 opened this issue Jan 28, 2021 · 1 comment
Open

Redux-React Basic Tutorial issues #1684

cniemann88 opened this issue Jan 28, 2021 · 1 comment
Labels

Comments

@cniemann88
Copy link

cniemann88 commented Jan 28, 2021

Not quiet sure where else to put this.

For the Basic Tutorial https://react-redux.js.org/introduction/basic-tutorial there are 3 issues.

Issue 1: The Sandbox Code: https://codesandbox.io/s/6vwyqrpqk3 uses react: 16.4.2, but needs at least 16.8.4 because of .memo()

Issue 2: The tutorial implements the connection for the VisibilityFilters, but it omits setting the filters
const VisibilityFilters = ({ activeFilter, setFilter }) => {

<span
key={`visibility-filter-${currentFilter}`}
className={cx(
  "filter",
  currentFilter === activeFilter && "filter--active"
)}
onClick={() => {} /** waiting for setFilter handler*/} <------this should be mentioned in the Tutorial, or filled in
>
{currentFilter}
</span>

Issue 3: Similar to issue 2, the tutorial doesnt implement the toggleTodo() in Todo.js.

Thanks!

@markerikson
Copy link
Contributor

markerikson commented Jan 28, 2021

The tutorial really needs to be rewritten anyway, to show use of hooks instead of class components and connect.

Right now the best tutorial is actually in the Redux core docs "Fundamentals" tutorial:

https://redux.js.org/tutorials/fundamentals/part-5-ui-react

Refs: #1574, #1575 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants