Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rendering doesn't always terminate when errors are thrown #278

Open
justusmattern27 opened this issue Sep 11, 2024 · 0 comments · May be fixed by #301
Open

rendering doesn't always terminate when errors are thrown #278

justusmattern27 opened this issue Sep 11, 2024 · 0 comments · May be fixed by #301
Labels
high-priority A feature / bug we strongly prioritize

Comments

@justusmattern27
Copy link
Member

we need to make sure that rendering always terminates when an error is thrown - for instance, when a user provides a video file that does not exist, renderVideo does log an error, but doesn't terminate
@justusmattern27 justusmattern27 changed the title always terminate when errors are thrown rendering doesn't always terminate when errors are thrown Sep 11, 2024
@justusmattern27 justusmattern27 added the high-priority A feature / bug we strongly prioritize label Sep 13, 2024
@justusmattern27 justusmattern27 linked a pull request Sep 23, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
high-priority A feature / bug we strongly prioritize
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: better error handling redotvideo/revideo
1 participant
@justusmattern27