Extended io-threads use-case to 100% gets and mixed reads/writes

redis · Dec 16, 2024 · c721f6c · c721f6c
1 parent e71239b
commit c721f6c
Show file tree

Hide file tree

Showing 15 changed files with 103 additions and 14 deletions.
diff --git a/pyproject.toml b/pyproject.toml
@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "redis-benchmarks-specification"
-version = "0.1.252"
+version = "0.1.256"
 description = "The Redis benchmarks specification describes the cross-language/tools requirements and expectations to foster performance and observability standards around redis related technologies. Members from both industry and academia, including organizations and individuals are encouraged to contribute."
 authors = ["filipecosta90 <[email protected]>","Redis Performance Group <[email protected]>"]
 readme = "Readme.md"

diff --git a/redis_benchmarks_specification/__compare__/compare.py b/redis_benchmarks_specification/__compare__/compare.py
@@ -804,21 +804,22 @@ def compute_regression_table(
     len_baseline_only_list = len(baseline_only_list)
     if len_baseline_only_list > 0:
         table_output += f"\n  WARNING: There were {len_baseline_only_list} benchmarks with datapoints only on baseline.\n\n"
-        baseline_only_test_names_str = "|".join([l[0] for l in baseline_only_list])
+        baseline_only_test_names_str = "|".join([l for l in baseline_only_list])
         table_output += (
             f"  Baseline only test regexp names: {baseline_only_test_names_str}\n\n"
         )
     len_comparison_only_list = len(comparison_only_list)
     if len_comparison_only_list > 0:
         table_output += f"\n  WARNING: There were {len_comparison_only_list} benchmarks with datapoints only on comparison.\n\n"
-        comparison_only_test_names_str = "|".join([l[0] for l in comparison_only_list])
+        comparison_only_test_names_str = "|".join([l for l in comparison_only_list])
         table_output += (
             f"  Comparison only test regexp names: {comparison_only_test_names_str}\n\n"
         )
     len_no_datapoints = len(no_datapoints_list)
     if len_no_datapoints > 0:
         table_output += f"\n  WARNING: There were {len_no_datapoints} benchmarks with NO datapoints for both baseline and comparison.\n\n"
-        no_datapoints_test_names_str = "|".join([l[0] for l in no_datapoints_list])
+        no_datapoints_test_names_str = "|".join([l for l in no_datapoints_list])
+
         table_output += (
             f"  NO DATAPOINTS test regexp names: {no_datapoints_test_names_str}\n\n"
         )

diff --git a/redis_benchmarks_specification/test-suites/memtier_benchmark-1key-hash-1K-fields-hgetall.yml b/redis_benchmarks_specification/test-suites/memtier_benchmark-1key-hash-1K-fields-hgetall.yml
diff --git a/...s_specification/test-suites/memtier_benchmark-1key-load-hash-1K-fields-with-5B-values.yml b/...s_specification/test-suites/memtier_benchmark-1key-load-hash-1K-fields-with-5B-values.yml
diff --git a/...marks_specification/test-suites/memtier_benchmark-1key-zrank-100K-elements-pipeline-1.yml b/...marks_specification/test-suites/memtier_benchmark-1key-zrank-100K-elements-pipeline-1.yml
@@ -0,0 +1,34 @@
+version: 0.4
+name: memtier_benchmark-1key-zrank-100K-elements-pipeline-1
+description: Runs memtier_benchmark, for a keyspace length of 1 SORTED SET key. The SORTED SET contains 100K elements and we query it using ZRANK.
+dbconfig:
+  configuration-parameters:
+    save: '""'
+  check:
+    keyspacelen: 1
+  preload_tool:
+    run_image: redislabs/memtier_benchmark:edge
+    tool: memtier_benchmark
+    arguments: --pipeline 50 --command="ZADD key1 __key__  __key__" --command-key-pattern=P --key-maximum 100000 --key-prefix "" -n allkeys --hide-histogram -t 1 -c 1
+  resources:
+    requests:
+      memory: 1g
+tested-groups:
+- sorted-set
+tested-commands:
+- zrank
+redis-topologies:
+- oss-standalone
+build-variants:
+- gcc:8.5.0-amd64-debian-buster-default
+- dockerhub
+clientconfig:
+  run_image: redislabs/memtier_benchmark:edge
+  tool: memtier_benchmark
+  arguments: --command="ZRANK key1 __key__" --key-maximum 100000 --command-key-pattern=R --key-prefix "" --hide-histogram --test-time 180 --pipeline 1 -c 1 -t 1
+  resources:
+    requests:
+      cpus: '4'
+      memory: 2g
+
+priority: 72
diff --git a/...hmarks_specification/test-suites/memtier_benchmark-1key-zrank-10M-elements-pipeline-1.yml b/...hmarks_specification/test-suites/memtier_benchmark-1key-zrank-10M-elements-pipeline-1.yml
@@ -0,0 +1,34 @@
+version: 0.4
+name: memtier_benchmark-1key-zrank-10M-elements-pipeline-1
+description: Runs memtier_benchmark, for a keyspace length of 1 SORTED SET key. The SORTED SET contains 10M elements and we query it using ZRANK.
+dbconfig:
+  configuration-parameters:
+    save: '""'
+  check:
+    keyspacelen: 1
+  preload_tool:
+    run_image: redislabs/memtier_benchmark:edge
+    tool: memtier_benchmark
+    arguments: --pipeline 50 --command="ZADD key1 __key__  __key__" --command-key-pattern=P --key-maximum 10000000 --key-prefix "" -n 1000000 --hide-histogram -t 10 -c 1
+  resources:
+    requests:
+      memory: 1g
+tested-groups:
+- sorted-set
+tested-commands:
+- zrank
+redis-topologies:
+- oss-standalone
+build-variants:
+- gcc:8.5.0-amd64-debian-buster-default
+- dockerhub
+clientconfig:
+  run_image: redislabs/memtier_benchmark:edge
+  tool: memtier_benchmark
+  arguments: --command="ZRANK key1 __key__" --key-maximum 10000000 --command-key-pattern=R --key-prefix "" --hide-histogram --test-time 180 --pipeline 1 -c 1 -t 1
+  resources:
+    requests:
+      cpus: '4'
+      memory: 2g
+
+priority: 72
diff --git a/...chmarks_specification/test-suites/memtier_benchmark-1key-zrank-1M-elements-pipeline-1.yml b/...chmarks_specification/test-suites/memtier_benchmark-1key-zrank-1M-elements-pipeline-1.yml
@@ -9,7 +9,7 @@ dbconfig:
   preload_tool:
     run_image: redislabs/memtier_benchmark:edge
     tool: memtier_benchmark
-    arguments: --command="ZADD key1 __key__  __key__" --command-key-pattern=P --key-maximum 1000000 --key-prefix "" -n 1000000 --hide-histogram -t 1 -c 1
+    arguments: --pipeline 50 --command="ZADD key1 __key__  __key__" --command-key-pattern=P --key-maximum 1000000 --key-prefix "" -n 100000 --hide-histogram -t 10 -c 1
   resources:
     requests:
       memory: 1g

diff --git a/...eys-load-string-with-512B-values copy.yml → ...d-string-with-512B-values-pipeline-10.yml b/...eys-load-string-with-512B-values copy.yml → ...d-string-with-512B-values-pipeline-10.yml
@@ -1,5 +1,5 @@
 version: 0.4
-name: memtier_benchmark-3Mkeys-load-string-with-512B-values
+name: memtier_benchmark-3Mkeys-load-string-with-512B-values-pipeline-10
 description: Runs memtier_benchmark, for a keyspace length of 3M keys loading STRINGs in which the value has a data size of 512 Bytes, with 650 clients running sequential SET commands.
 dbconfig:
   configuration-parameters:
@@ -17,15 +17,13 @@ redis-topologies:
 - oss-standalone-04-io-threads
 - oss-standalone-08-io-threads
 - oss-standalone-16-io-threads
-- oss-standalone-32-io-threads
-- oss-standalone-64-io-threads
 build-variants:
 - gcc:8.5.0-amd64-debian-buster-default
 - dockerhub
 clientconfig:
   run_image: redislabs/memtier_benchmark:edge
   tool: memtier_benchmark
-  arguments: '"--data-size" "512" --ratio 1:0 --key-pattern P:P --key-minimum=1 --key-maximum 3000000 --test-time 180 -c 50 -t 13 --hide-histogram'
+  arguments: '"--data-size" "512" --pipeline 10 --ratio 1:0 --key-pattern P:P --key-minimum=1 --key-maximum 3000000 --test-time 180 -c 50 -t 13 --hide-histogram'
   resources:
     requests:
       cpus: '13'

diff --git a/...marks_specification/test-suites/memtier_benchmark-3Mkeys-load-string-with-512B-values.yml b/...marks_specification/test-suites/memtier_benchmark-3Mkeys-load-string-with-512B-values.yml
@@ -17,8 +17,6 @@ redis-topologies:
 - oss-standalone-04-io-threads
 - oss-standalone-08-io-threads
 - oss-standalone-16-io-threads
-- oss-standalone-32-io-threads
-- oss-standalone-64-io-threads
 build-variants:
 - gcc:8.5.0-amd64-debian-buster-default
 - dockerhub

diff --git a/...st-suites/memtier_benchmark-3Mkeys-string-get-with-1KiB-values-pipeline-10-2000_conns.yml b/...st-suites/memtier_benchmark-3Mkeys-string-get-with-1KiB-values-pipeline-10-2000_conns.yml
@@ -17,6 +17,10 @@ tested-commands:
 - set
 redis-topologies:
 - oss-standalone
+- oss-standalone-02-io-threads
+- oss-standalone-04-io-threads
+- oss-standalone-08-io-threads
+- oss-standalone-16-io-threads
 build-variants:
 - gcc:8.5.0-amd64-debian-buster-default
 - dockerhub

diff --git a/...est-suites/memtier_benchmark-3Mkeys-string-get-with-1KiB-values-pipeline-10-400_conns.yml b/...est-suites/memtier_benchmark-3Mkeys-string-get-with-1KiB-values-pipeline-10-400_conns.yml
@@ -17,6 +17,10 @@ tested-commands:
 - set
 redis-topologies:
 - oss-standalone
+- oss-standalone-02-io-threads
+- oss-standalone-04-io-threads
+- oss-standalone-08-io-threads
+- oss-standalone-16-io-threads
 build-variants:
 - gcc:8.5.0-amd64-debian-buster-default
 - dockerhub

diff --git a/...test-suites/memtier_benchmark-3Mkeys-string-get-with-1KiB-values-pipeline-10-40_conns.yml b/...test-suites/memtier_benchmark-3Mkeys-string-get-with-1KiB-values-pipeline-10-40_conns.yml
@@ -17,6 +17,10 @@ tested-commands:
 - set
 redis-topologies:
 - oss-standalone
+- oss-standalone-02-io-threads
+- oss-standalone-04-io-threads
+- oss-standalone-08-io-threads
+- oss-standalone-16-io-threads
 build-variants:
 - gcc:8.5.0-amd64-debian-buster-default
 - dockerhub

diff --git a/...s/memtier_benchmark-3Mkeys-string-mixed-20-80-with-512B-values-pipeline-10-2000_conns.yml b/...s/memtier_benchmark-3Mkeys-string-mixed-20-80-with-512B-values-pipeline-10-2000_conns.yml
@@ -17,6 +17,10 @@ tested-commands:
 - set
 redis-topologies:
 - oss-standalone
+- oss-standalone-02-io-threads
+- oss-standalone-04-io-threads
+- oss-standalone-08-io-threads
+- oss-standalone-16-io-threads
 build-variants:
 - gcc:8.5.0-amd64-debian-buster-default
 - dockerhub

diff --git a/...es/memtier_benchmark-3Mkeys-string-mixed-20-80-with-512B-values-pipeline-10-400_conns.yml b/...es/memtier_benchmark-3Mkeys-string-mixed-20-80-with-512B-values-pipeline-10-400_conns.yml
@@ -17,6 +17,10 @@ tested-commands:
 - set
 redis-topologies:
 - oss-standalone
+- oss-standalone-02-io-threads
+- oss-standalone-04-io-threads
+- oss-standalone-08-io-threads
+- oss-standalone-16-io-threads
 build-variants:
 - gcc:8.5.0-amd64-debian-buster-default
 - dockerhub

diff --git a/...s/memtier_benchmark-3Mkeys-string-mixed-20-80-with-512B-values-pipeline-10-5200_conns.yml b/...s/memtier_benchmark-3Mkeys-string-mixed-20-80-with-512B-values-pipeline-10-5200_conns.yml
@@ -17,6 +17,10 @@ tested-commands:
 - set
 redis-topologies:
 - oss-standalone
+- oss-standalone-02-io-threads
+- oss-standalone-04-io-threads
+- oss-standalone-08-io-threads
+- oss-standalone-16-io-threads
 build-variants:
 - gcc:8.5.0-amd64-debian-buster-default
 - dockerhub