Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERR Protocol error: too big inline request (Redis::CommandError) #104

Closed
Jakanapes opened this issue Mar 21, 2023 · 3 comments
Closed

ERR Protocol error: too big inline request (Redis::CommandError) #104

Jakanapes opened this issue Mar 21, 2023 · 3 comments

Comments

@Jakanapes
Copy link

Linked issue: redis/redis-rb#1185

Redis 5.3.3
Ruby 3.1.3
Rails 7.0.4.2
redis gem 5.0.6
resque gem 2.4.0

Just upgraded the redis/resque gems and their dependencies and am getting this intermittent error ERROR -- : ERR Protocol error: too big inline request (Redis::CommandError)

The backtrace is not super helpful

E, [2023-03-14T14:41:13.543261 #44489] ERROR -- : ERR Protocol error: too big inline request (Redis::CommandError)
.....shared/bundle/ruby/3.1.0/gems/redis-5.0.6/lib/redis/subscribe.rb:52:in subscription' .....shared/bundle/ruby/3.1.0/gems/redis-5.0.6/lib/redis/subscribe.rb:17:in subscribe'
.....shared/bundle/ruby/3.1.0/gems/redis-5.0.6/lib/redis.rb:188:in _subscription' .....shared/bundle/ruby/3.1.0/gems/redis-5.0.6/lib/redis/commands/pubsub.rb:17:in subscribe'
.....shared/bundle/ruby/3.1.0/gems/actioncable-7.0.4.2/lib/action_cable/subscription_adapter/redis.rb:83:in block in listen' .....shared/bundle/ruby/3.1.0/gems/redis-client-0.12.1/lib/redis_client.rb:645:in ensure_connected'
.....shared/bundle/ruby/3.1.0/gems/redis-5.0.6/lib/redis/client.rb:104:in disable_reconnection' .....shared/bundle/ruby/3.1.0/gems/redis-5.0.6/lib/redis.rb:79:in without_reconnect'
.....shared/bundle/ruby/3.1.0/gems/actioncable-7.0.4.2/lib/action_cable/subscription_adapter/redis.rb:80:in listen' .....shared/bundle/ruby/3.1.0/gems/actioncable-7.0.4.2/lib/action_cable/subscription_adapter/redis.rb:154:in block in ensure_listener_running'

seems to indicate that action_cable is involved, but we use it a lot and having trouble tracking it down. I can't reproduce it and it appears on calls that don't trigger any actioncable actions.

The error is generated in redis, which has not changed, but looking at the gem difference, the error being raised in subscribe.rb is new. Am I looking at something that was happening all along, but was being swallowed by earlier versions of the redis gem?

Looking at the c extension code to try to figure out if there's a path that could be taken that doesn't prepend with "*" so it's treated as inline, but not having much luck.

@byroot
Copy link
Member

byroot commented Mar 21, 2023

Both gems are maintained by myself, there isn't much to gain in opening a second issue

@byroot byroot closed this as completed Mar 21, 2023
@Jakanapes
Copy link
Author

ah, my apologies, I'm tearing my hair out.

@byroot
Copy link
Member

byroot commented Mar 21, 2023

Yeah, no worries, I understand that these issues are painful to debug.

Unfortunately I don't have much ideas how to debug that further.

One avenue could be to report it to redis-server, but I don't know if your server version is still supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants