Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New line at end of map required when multiple topic maps are used #166

Open
gabriel-ocp opened this issue Apr 27, 2022 · 1 comment
Open

Comments

@gabriel-ocp
Copy link

If you do not leave a blank line at the end of each topic map, it seems that when they are merged into the temporary file, the build will fail.

This can be rectified by adding in a new line after each map is read, in the merge code:

lib/ascii_binder/engine.rb:

    # topic map files are in the _topic_maps folder

    # create a combined temp file with all topic maps
    tf = Tempfile.new("#{TOPIC_MAP_FILENAME}")

    Dir.glob("#{topic_map_folder}/*.yml").each do |filename|
      lines = IO.read(filename)
      tf << lines
      tf.write "\n"
    end
@rohennes
Copy link

rohennes commented Aug 4, 2022

I have replicated the issue with my local asciibinder build. Using @gabriel-ocp's container image with his updated version of asciibinder, I verified the fixes worked as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants