Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We should remove the sync folder settings for rsync from the default Vagrantfile #366

Open
LalatenduMohanty opened this issue Feb 29, 2016 · 1 comment
Open

We should remove the sync folder settings for rsync from the default Vagrantfile #366

LalatenduMohanty opened this issue Feb 29, 2016 · 1 comment

Comments

@LalatenduMohanty
Copy link

Because the default settings does not make any sense for a Vagrant guest running on a Windows machine. Windows does not have rsync installed so even if vagrant up tells that the sync happened on Windows, but it did not do any sync

Vagrant.configure('2') do |config|
        config.vm.synced_folder ".", "/vagrant", type: "rsync"
LalatenduMohanty added a commit to LalatenduMohanty/imagefactory that referenced this issue Feb 29, 2016
@LalatenduMohanty
Removing the sync folder option using rsync
ef0822b 
As it is not applicable on Virtualbox running on Windows

Fixes issue redhat-imaging#366

Signed-off-by: Lalatendu Mohanty <[email protected]>
This was referenced Feb 29, 2016
Closed
Closed
LalatenduMohanty added a commit to LalatenduMohanty/imagefactory that referenced this issue Jul 4, 2016
@LalatenduMohanty
Removing the sync folder option using rsync
6443c02 
As it is not applicable on Virtualbox running on Windows

Fixes issue redhat-imaging#366

Signed-off-by: Lalatendu Mohanty <[email protected]>
LalatenduMohanty added a commit to LalatenduMohanty/imagefactory that referenced this issue Jul 4, 2016
@LalatenduMohanty
Removing the sync folder option using rsync
1549b07 
As it is not applicable on Virtualbox running on Windows

Fixes issue redhat-imaging#366

Signed-off-by: Lalatendu Mohanty <[email protected]>
LalatenduMohanty added a commit to LalatenduMohanty/imagefactory that referenced this issue Sep 1, 2016
@LalatenduMohanty
Removing the sync folder option using rsync
87c8e27 
As it is not applicable on Virtualbox running on Windows

Fixes issue redhat-imaging#366

Signed-off-by: Lalatendu Mohanty <[email protected]>
@lpancescu
Copy link
Contributor

Removing that line completely would results in vagrant up waiting until the timeout elapses (5 minutes by default), and the process ends with an error code. We don't include the VirtualBox Guest Additions in the official CentOS Vagrant images - this would be a breaking change for us (at least as long as we can't customize the embedded Vagrantfile).

CentOS/sig-cloud-instance-build#58 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lpancescu @LalatenduMohanty