Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for filtering out environment variables #51

Open
omajid opened this issue Aug 25, 2021 · 2 comments
Open

Add support for filtering out environment variables #51

omajid opened this issue Aug 25, 2021 · 2 comments

Comments

@omajid
Copy link
Member

omajid commented Aug 25, 2021

The test runner (this repository) as well as the test cases themselves are written in .NET.

Sometimes we will need to apply hacks/workarounds to get the test runner working, such as setting environment variables to control what the .NET runtime does, or what system library is loaded, or whether a library feature like invariant mode is enabled. We wouldn't generally want to pass these to the tests themselves, because we want the tests to run in a pristine environment, unaffected by hacks/workarounds applied to the test runner

We should do a few things:

  • Filter out some environment variables by default, such as those beginning with DOTNET_, and CLR_.
  • Maybe: a way to pass some of those variables along, basically, selectively undo'ing the previous point.
  • Let the user provide some additional environment variables to filter out via file or the command line.
@omajid
Copy link
Member Author

omajid commented Aug 25, 2021

The first user of this would be anyone adapting OpenSSL 3.0. The test runner being a netcoreapp3.1 application doesn't support OpenSSL 3.0. We would like to force it to OpenSSL 1.1, but then let the actual test cases use OpenSSL 3.0 (or 1.1, whatever the SDK/Runtime under test decide to do). Part of the forcing-OpenSSL-1.1 involves setting environment variables like OPENSSL_CONF.

@omajid omajid added the blocker label Aug 25, 2021
omajid added a commit to omajid/dotnet-bunny that referenced this issue Aug 26, 2021
omajid added a commit to omajid/dotnet-bunny that referenced this issue Aug 26, 2021
omajid added a commit that referenced this issue Aug 26, 2021
Only enabled for OPENSSL_CONF for now.

See: #51
@omajid omajid removed the blocker label Aug 26, 2021
@omajid
Copy link
Member Author

omajid commented Sep 3, 2024

We think this is a lower priority issue that someone can address if/when they feel like it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant